Remove comment referencing previous defensive programming #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitch Martin <[email protected]>
ghost
self-assigned this
xgreenx
approved these changes
Feb 16, 2023
xgreenx
deleted the
mitch-fuel/remove-deprecated-block-id-comparison-comment
branch
xgreenx
added a commit
that referenced
this pull request
Feb 21, 2023
## What's Changed * RESERVED_NODES and BOOTSTRAP_NODES conditional by @rfuelsh in #1020 * barebones e2e test client by @Voxelot in #1003 * Graceful Shutdown for all services by @xgreenx in #1018 * Don't startup p2p or sync services if p2p isn't configured by @Voxelot in #1021 * update to fuel-vm 0.26.1 by @Voxelot in #1022 * Remove comment referencing previous defensive programming by @mitch-fuel in #1024 * Add RUST_LOG option to deployment charts & increase max_transmit_size by @Voxelot in #1025 * additional integ tests for resources to spend by @Voxelot in #1026 * Disable pagination args for balances by @Voxelot in #1027 * Add e2e test to check that Bob can send money back to Alice by @xgreenx in #1029 * Predicate error handling by @Voxelot in #1030 * Use composite actions by @tirkesi in #1032 * Pruning of the transaction by TTL by @xgreenx in #1033 ## New Contributors * @tirkesi made their first contribution in #1032 **Full Changelog**: v0.17.2...v0.17.3
crypto523
pushed a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
## What's Changed * RESERVED_NODES and BOOTSTRAP_NODES conditional by @rfuelsh in FuelLabs/fuel-core#1020 * barebones e2e test client by @Voxelot in FuelLabs/fuel-core#1003 * Graceful Shutdown for all services by @xgreenx in FuelLabs/fuel-core#1018 * Don't startup p2p or sync services if p2p isn't configured by @Voxelot in FuelLabs/fuel-core#1021 * update to fuel-vm 0.26.1 by @Voxelot in FuelLabs/fuel-core#1022 * Remove comment referencing previous defensive programming by @mitch-fuel in FuelLabs/fuel-core#1024 * Add RUST_LOG option to deployment charts & increase max_transmit_size by @Voxelot in FuelLabs/fuel-core#1025 * additional integ tests for resources to spend by @Voxelot in FuelLabs/fuel-core#1026 * Disable pagination args for balances by @Voxelot in FuelLabs/fuel-core#1027 * Add e2e test to check that Bob can send money back to Alice by @xgreenx in FuelLabs/fuel-core#1029 * Predicate error handling by @Voxelot in FuelLabs/fuel-core#1030 * Use composite actions by @tirkesi in FuelLabs/fuel-core#1032 * Pruning of the transaction by TTL by @xgreenx in FuelLabs/fuel-core#1033 ## New Contributors * @tirkesi made their first contribution in FuelLabs/fuel-core#1032 **Full Changelog**: FuelLabs/fuel-core@v0.17.2...v0.17.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change led to a collapsing of the block validation logic to check and compare the final block id instead of the transactions root and messages root separately beforehand. This check was redundant and thus this comment was relevant until @xgreenx recently simplified the checks.