Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESERVED_NODES and BOOTSTRAP_NODES conditional #1020

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

rfuelsh
Copy link
Member

@rfuelsh rfuelsh commented Feb 16, 2023

we're passing empty env vars for RESERVED_NODES and BOOTSTRAP_NODES, we can either make those env vars conditional or I can make the CLI more tolerant of those env vars being set without values

@rfuelsh rfuelsh self-assigned this Feb 16, 2023
@rfuelsh rfuelsh requested review from Voxelot and tirkesi February 16, 2023 00:55
@rfuelsh rfuelsh merged commit b023ae4 into master Feb 16, 2023
@rfuelsh rfuelsh deleted the feature/adjust-helm-node-envs branch February 16, 2023 01:36
xgreenx added a commit that referenced this pull request Feb 21, 2023
## What's Changed
* RESERVED_NODES and BOOTSTRAP_NODES conditional by @rfuelsh in
#1020
* barebones e2e test client by @Voxelot in
#1003
* Graceful Shutdown for all services by @xgreenx in
#1018
* Don't startup p2p or sync services if p2p isn't configured by @Voxelot
in #1021
* update to fuel-vm 0.26.1 by @Voxelot in
#1022
* Remove comment referencing previous defensive programming by
@mitch-fuel in #1024
* Add RUST_LOG option to deployment charts & increase max_transmit_size
by @Voxelot in #1025
* additional integ tests for resources to spend by @Voxelot in
#1026
* Disable pagination args for balances by @Voxelot in
#1027
* Add e2e test to check that Bob can send money back to Alice by
@xgreenx in #1029
* Predicate error handling by @Voxelot in
#1030
* Use composite actions by @tirkesi in
#1032
* Pruning of the transaction by TTL by @xgreenx in
#1033

## New Contributors
* @tirkesi made their first contribution in
#1032

**Full Changelog**:
v0.17.2...v0.17.3
crypto523 pushed a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
## What's Changed
* RESERVED_NODES and BOOTSTRAP_NODES conditional by @rfuelsh in
FuelLabs/fuel-core#1020
* barebones e2e test client by @Voxelot in
FuelLabs/fuel-core#1003
* Graceful Shutdown for all services by @xgreenx in
FuelLabs/fuel-core#1018
* Don't startup p2p or sync services if p2p isn't configured by @Voxelot
in FuelLabs/fuel-core#1021
* update to fuel-vm 0.26.1 by @Voxelot in
FuelLabs/fuel-core#1022
* Remove comment referencing previous defensive programming by
@mitch-fuel in FuelLabs/fuel-core#1024
* Add RUST_LOG option to deployment charts & increase max_transmit_size
by @Voxelot in FuelLabs/fuel-core#1025
* additional integ tests for resources to spend by @Voxelot in
FuelLabs/fuel-core#1026
* Disable pagination args for balances by @Voxelot in
FuelLabs/fuel-core#1027
* Add e2e test to check that Bob can send money back to Alice by
@xgreenx in FuelLabs/fuel-core#1029
* Predicate error handling by @Voxelot in
FuelLabs/fuel-core#1030
* Use composite actions by @tirkesi in
FuelLabs/fuel-core#1032
* Pruning of the transaction by TTL by @xgreenx in
FuelLabs/fuel-core#1033

## New Contributors
* @tirkesi made their first contribution in
FuelLabs/fuel-core#1032

**Full Changelog**:
FuelLabs/fuel-core@v0.17.2...v0.17.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants