Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore broken audio tracks for videos with multiple audio tracks #3851

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Ignore broken audio tracks for videos with multiple audio tracks #3851

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ade288
Ignore broken audio tracks for videos with multiple audio tracks
absidue Aug 5, 2023
32b72ba
Merge branch 'development' into fix-broken-audio-track
absidue Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/renderer/views/Watch/Watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,14 @@ export default defineComponent({
/** @type {import('youtubei.js').Misc.Format[][]} */
const sourceLists = []

audioFormats.forEach(format => {
for (const format of audioFormats) {
// Some videos with multiple audio tracks, have a broken one, that doesn't have any audio track information
// It seems to be the same as default audio track but broken
// At the time of writing, this video has a broken audio track: https://youtu.be/UJeSWbR6W04
if (!format.audio_track) {
continue
}

const index = ids.indexOf(format.audio_track.id)
if (index === -1) {
ids.push(format.audio_track.id)
Expand Down Expand Up @@ -632,7 +639,7 @@ export default defineComponent({
} else {
sourceLists[index].push(format)
}
})
}

for (let i = 0; i < audioTracks.length; i++) {
audioTracks[i].sourceList = this.createLocalAudioSourceList(sourceLists[i])
Expand Down