-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore broken audio tracks for videos with multiple audio tracks #3851
Merged
FreeTubeBot
merged 2 commits into
FreeTubeApp:development
from
absidue:fix-broken-audio-track
Aug 20, 2023
Merged
Ignore broken audio tracks for videos with multiple audio tracks #3851
FreeTubeBot
merged 2 commits into
FreeTubeApp:development
from
absidue:fix-broken-audio-track
Aug 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Can you try rebasing this PR? I want to see if the auto merge change fixes the issue 😄 |
absidue
force-pushed
the
fix-broken-audio-track
branch
from
August 10, 2023 20:22
38c4cda
to
6ade288
Compare
@ChunkyProgrammer looks like the auto merge workflow is fixed |
github-actions
bot
added
the
PR: waiting for review
For PRs that are complete, tested, and ready for review
label
Aug 19, 2023
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
August 19, 2023 17:16
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PikachuEXE
approved these changes
Aug 20, 2023
ChunkyProgrammer
approved these changes
Aug 20, 2023
github-actions
bot
removed
the
PR: waiting for review
For PRs that are complete, tested, and ready for review
label
Aug 20, 2023
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* development: Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897) Bump version number to v0.19.0 Fix linting issues Translated using Weblate (Bulgarian) Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851) local API: Add support for PageHeader hashtag header (FreeTubeApp#3896) Translated using Weblate (German) Translated using Weblate (Swedish) Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895) # Conflicts: # src/renderer/components/ft-list-playlist/ft-list-playlist.vue # src/renderer/components/watch-video-playlist/watch-video-playlist.vue
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* feature/playlist-2023-05: Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897) Bump version number to v0.19.0 Fix linting issues Translated using Weblate (Bulgarian) Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851) local API: Add support for PageHeader hashtag header (FreeTubeApp#3896) Translated using Weblate (German) Translated using Weblate (Swedish) Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore broken audio tracks for videos with multiple audio tracks
Pull Request Type
Related issue
closes #3843
LuanRT/YouTube.js#462
Description
Some videos with multiple audio tracks have a broken one, which seems to be indentical to the default one but without audio track information, as the YouTube.js DASH manifest generation and FreeTube's audio only implementions were designed around videos not having broken audio tracks, they break when they encounter one. This pull request and the accompanying YouTube.js one ignore the broken track.
Testing
Broken video: https://youtu.be/UJeSWbR6W04
Normal video: https://youtu.be/yFswDJPvtPY