Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore broken audio tracks for videos with multiple audio tracks #3851

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented Aug 5, 2023

Ignore broken audio tracks for videos with multiple audio tracks

Pull Request Type

  • Bugfix

Related issue

closes #3843

LuanRT/YouTube.js#462

Description

Some videos with multiple audio tracks have a broken one, which seems to be indentical to the default one but without audio track information, as the YouTube.js DASH manifest generation and FreeTube's audio only implementions were designed around videos not having broken audio tracks, they break when they encounter one. This pull request and the accompanying YouTube.js one ignore the broken track.

Testing

Broken video: https://youtu.be/UJeSWbR6W04
Normal video: https://youtu.be/yFswDJPvtPY

@ChunkyProgrammer
Copy link
Member

Can you try rebasing this PR? I want to see if the auto merge change fixes the issue 😄

@absidue absidue force-pushed the fix-broken-audio-track branch from 38c4cda to 6ade288 Compare August 10, 2023 20:22
@absidue
Copy link
Member Author

absidue commented Aug 10, 2023

@ChunkyProgrammer looks like the auto merge workflow is fixed

@absidue absidue marked this pull request as ready for review August 19, 2023 17:13
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 19, 2023 17:13
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 19, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit 4d4dcba into FreeTubeApp:development Aug 20, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 20, 2023
@absidue absidue deleted the fix-broken-audio-track branch August 20, 2023 08:15
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 21, 2023
* development:
  Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897)
  Bump version number to v0.19.0
  Fix linting issues
  Translated using Weblate (Bulgarian)
  Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851)
  local API: Add support for PageHeader hashtag header (FreeTubeApp#3896)
  Translated using Weblate (German)
  Translated using Weblate (Swedish)
  Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895)

# Conflicts:
#	src/renderer/components/ft-list-playlist/ft-list-playlist.vue
#	src/renderer/components/watch-video-playlist/watch-video-playlist.vue
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 21, 2023
* feature/playlist-2023-05:
  Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897)
  Bump version number to v0.19.0
  Fix linting issues
  Translated using Weblate (Bulgarian)
  Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851)
  local API: Add support for PageHeader hashtag header (FreeTubeApp#3896)
  Translated using Weblate (German)
  Translated using Weblate (Swedish)
  Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Video player TypeError: Cannot read properties of undefined (reading 'id')
5 participants