Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Coroutines removal PR590 #663

Closed
wants to merge 2 commits into from
Closed

Revert Coroutines removal PR590 #663

wants to merge 2 commits into from

Conversation

alfred2g
Copy link
Contributor

This reverts commit b3b097b.

Revert Coroutines #590

Description

Revert Removing co-routines as some customers are still using it
(warning) co-routines is no longer under development

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#661

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alfred2g alfred2g requested a review from a team as a code owner April 19, 2023 00:44
@alfred2g alfred2g changed the title Revert "README.md: Remove coroutine references." Revert Coroutines removal PR590 Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (97434a4) 94.46% compared to head (5acc13e) 94.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files           6        6           
  Lines        2422     2422           
  Branches      594      594           
=======================================
  Hits         2288     2288           
  Misses         85       85           
  Partials       49       49           
Flag Coverage Δ
unittests 94.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mancent Mancent linked an issue May 21, 2023 that may be closed by this pull request
@AniruddhaKanhere
Copy link
Member

Superseded by #685

@amazonKamath amazonKamath deleted the revert_coroutines branch July 19, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

> - [ ] ```
2 participants