Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Where is croutine.c in the main branch? #661

Closed
jwestmoreland opened this issue Apr 14, 2023 · 9 comments
Closed

[BUG] Where is croutine.c in the main branch? #661

jwestmoreland opened this issue Apr 14, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@jwestmoreland
Copy link

Hello All,

Looked in the docs - at least what I could find in the rev history - has croutine.c been removed?

Just wondering - maybe I missed something.

It's there in the v10.5.1 branch/tag.

Thanks!
John W.

@jwestmoreland jwestmoreland added the bug Something isn't working label Apr 14, 2023
@rawalexe
Copy link
Member

rawalexe commented Apr 14, 2023

Hello John W.,
We have depreciated croutine.c you can find the place holder here. Please use v10.5.1 if you still need them.

Please let me know if have any other queries.

Best Regards,
Anubhav Rawal

@jwestmoreland
Copy link
Author

Anubhav,

Has the functionality in croutine.c been incorporated someplace else?

Thanks,
John W.

@rawalexe
Copy link
Member

Greetings John,
We noticed that the c file hadn't been touched in a long time and we never had a questions or pull requests on it. After a careful considerations we felt that it was safe to remove the file as most folks were using larger processors and weren't in need of the file. However if you still need them, you can find them from the v10.5.1 release . As the file has been stable for a long time you can still use the past version of the file.

Hopefully this helps. Please let us know if you have more questions.

Best Regards,
Anubhav Rawal

@jwestmoreland
Copy link
Author

Anubhav,

OK - so, no one's using a stack challenged processor these days, OK.

Or - some others may notice when 10.5.1+ is released.

Hopefully Richard sees this comment and chimes in.

Thanks,
John W.

@RichardBarry
Copy link
Contributor

Hi John - noted - I will discuss with the team Monday.

@jwestmoreland
Copy link
Author

Hello Richard,

Interested to hear what's decided.

I have a few things in the pipeline here - on one especially that's 'ram challenged' - pretty sure we will end up using co-routines.

Thanks!
John

@RichardBarry
Copy link
Contributor

Hi John - we decided to add the file back into the git repo, and then update co-routine related website pages noting co-routines are no longer under development. I hope that is agreeable for you.

@jwestmoreland
Copy link
Author

Hello Richard,

That's fine.

Thanks!
John

@AniruddhaKanhere
Copy link
Member

Since the above PR has been merged, we will close this issue. Please feel free to reopen this thread if you feel that your issue wasn't resolved correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants