Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo for replaceProcessGroup #1510

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Correct typo for replaceProcessGroup #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1beta1/foundationdbcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ type ProcessGroupStatus struct {
// This is only used within the reconciliation process, and should not be considered authoritative.
// Deprecated: Use ExclusionTimestamp instead.
Excluded bool `json:"excluded,omitempty"`
// ExcludedTimestamp defines when the process group has been fully excluded.
// ExclusionTimestamp defines when the process group has been fully excluded.
// This is only used within the reconciliation process, and should not be considered authoritative.
ExclusionTimestamp *metav1.Time `json:"exclusionTimestamp,omitempty"`
// ExclusionSkipped determines if exclusion has been skipped for a process, which will allow the process group to be removed without exclusion.
Expand Down
2 changes: 1 addition & 1 deletion api/v1beta2/foundationdbcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ type ProcessGroupStatus struct {
Addresses []string `json:"addresses,omitempty"`
// RemoveTimestamp if not empty defines when the process group was marked for removal.
RemovalTimestamp *metav1.Time `json:"removalTimestamp,omitempty"`
// ExcludedTimestamp defines when the process group has been fully excluded.
// ExclusionTimestamp defines when the process group has been fully excluded.
// This is only used within the reconciliation process, and should not be considered authoritative.
ExclusionTimestamp *metav1.Time `json:"exclusionTimestamp,omitempty"`
// ExclusionSkipped determines if exclusion has been skipped for a process, which will allow the process group to be removed without exclusion.
Expand Down
2 changes: 1 addition & 1 deletion docs/cluster_spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ ProcessGroupStatus represents the status of a ProcessGroup.
| processClass | ProcessClass represents the class the process group has. | [ProcessClass](#processclass) | false |
| addresses | Addresses represents the list of addresses the process group has been known to have. | []string | false |
| removalTimestamp | RemoveTimestamp if not empty defines when the process group was marked for removal. | *metav1.Time | false |
| exclusionTimestamp | ExcludedTimestamp defines when the process group has been fully excluded. This is only used within the reconciliation process, and should not be considered authoritative. | *metav1.Time | false |
| exclusionTimestamp | ExclusionTimestamp defines when the process group has been fully excluded. This is only used within the reconciliation process, and should not be considered authoritative. | *metav1.Time | false |
| exclusionSkipped | ExclusionSkipped determines if exclusion has been skipped for a process, which will allow the process group to be removed without exclusion. | bool | false |
| processGroupConditions | ProcessGroupConditions represents a list of degraded conditions that the process group is in. | []*[ProcessGroupCondition](#processgroupcondition) | false |

Expand Down
5 changes: 3 additions & 2 deletions kubectl-fdb/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@ package cmd
import (
"bufio"
"fmt"
"github.com/fatih/color"
"log"
"math/rand"
"os"
"time"

"github.com/fatih/color"

johscheuer marked this conversation as resolved.
Show resolved Hide resolved
"strings"

"github.com/spf13/viper"
Expand Down Expand Up @@ -94,7 +95,7 @@ func NewRootCmd(streams genericclioptions.IOStreams) *cobra.Command {
return cmd
}

// confirmAction requests a user to confirm it's action
// confirmAction requests a user to confirm its action
func confirmAction(action string) bool {
reader := bufio.NewReader(os.Stdin)

Expand Down