Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo for replaceProcessGroup #1510

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

xumengpanda
Copy link
Contributor

Description

ReplaceProcessGroup procedure has typo in its help message and comment.
This PR fixex the typos.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
    No functional change.

Testing

No testing since it's not changing functionality.

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b3bf5d53efbf7a8d786b01a67e6835b40e2d3973
  • Duration 3:10:10
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run make clean all to ensure everything is generated properly. You also have to change the code in v1beta2, v1beta1 is read-only.

kubectl-fdb/cmd/root.go Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a654e4f
  • Duration 1:17:21
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@xumengpanda
Copy link
Contributor Author

The PR test failure is not relevant to this PR. It seems indicating the buggify feature has bug?

[FAILED] [56.158 seconds]
Operator
/codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:117
 using the buggify option to ignore a process during the restart
 /codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:869
   [It] should not restart the process on the ignore list
   /codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:910

 Failed after 15.036s.
 Expected
     <bool>: false
 to be true
 In [It] at: /codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:942

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johscheuer johscheuer added the documentation Improvements or additions to documentation label Feb 22, 2023
@johscheuer
Copy link
Member

The PR test failure is not relevant to this PR. It seems indicating the buggify feature has bug?

[FAILED] [56.158 seconds]
Operator
/codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:117
 using the buggify option to ignore a process during the restart
 /codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:869
   [It] should not restart the process on the ignore list
   /codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:910

 Failed after 15.036s.
 Expected
     <bool>: false
 to be true
 In [It] at: /codebuild/output/src594396191/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator/operator_test.go:942

This could also be an issue with the test setup, we already have an issue to investigate this failure.

@johscheuer johscheuer merged commit 482a832 into FoundationDB:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants