-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x Types Issue: FontAwesomeIconProps missing values #415
Comments
brandon-mork
pushed a commit
to brandon-mork/vue-fontawesome-issue-415
that referenced
this issue
Nov 11, 2022
…o match actual expected props in FontAwesomeIcon.js.
@brandon-mork --- I have added in the missing sizes. I will go ahead and close this issues. Let us know if anything else pops up. |
@jasonlundien your PR fails to sync the other props available on the component but missing in the types... Logged as a separate issue: #428 Provided PR would have fixed all of the documented issues: #416 |
This was referenced May 29, 2024
This was referenced Jun 29, 2024
This was referenced Jul 29, 2024
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Types in index.d.ts FontAwesomeIconProps do not match actual expected props in FontAwesomeIcon.js.
Expected behavior
Exact match of supported props and associated types definition.
Reproduction
In any typescript app consuming v3.0.2 of vue-fontawesome, attempt to utilize prop size="xl". See type error:
error TS2322: Type '"xl"' is not assignable to type '"lg" | "xs" | "sm" | "1x" | "2x" | "3x" | "4x" | "5x" | "6x" | "7x" | "8x" | "9x" | "10x" | undefined'.
Additional context
Issue introduced by: #366
Exact diff of expected types
The text was updated successfully, but these errors were encountered: