Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Types Issue: FontAwesomeIconProps missing values #428

Closed
brandon-mork opened this issue Jan 3, 2023 · 3 comments · Fixed by #429
Closed

3.x Types Issue: FontAwesomeIconProps missing values #428

brandon-mork opened this issue Jan 3, 2023 · 3 comments · Fixed by #429
Assignees
Labels

Comments

@brandon-mork
Copy link

brandon-mork commented Jan 3, 2023

Describe the bug
Types in index.d.ts FontAwesomeIconProps do not match actual expected props in FontAwesomeIcon.js.

Expected behavior
Exact match of supported props and associated types definition.

Reproduction
Unintuitive breakage due to missing types, string "false" evaluates to true:

Functioning code to pass boolean false value instead of string, which consuming developer would know to use if types were present:

Additional context
Issue introduced by: #366
PR merged under #415 fixed one piece of the issue, but left much of the issue remaining.

Exact diff of expected types

+ bounce?: boolean
+ shake?: boolean
+ beat?: boolean
+ fade?: boolean
+ beatFade?: boolean
+ flash?: boolean
+ spinPulse?: boolean
+ spinReverse?: boolean
@jasonlundien
Copy link
Member

@brandon-mork ---

Oh my goodness, you are right, I missed them... somehow (I have no idea how).

I will get this PR submitted and merged as well. Thank you !!!

@jasonlundien jasonlundien self-assigned this Jan 3, 2023
@jasonlundien jasonlundien linked a pull request Jan 3, 2023 that will close this issue
@brandon-mork
Copy link
Author

You rock- thanks @jasonlundien!! :)

@jasonlundien
Copy link
Member

@brandon-mork ---

PR merged. So I am going to go ahead and close this one now. Thanks again for your help.

Also, I am going to add you as a contributor unless you tell me other wise. Have a great one !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants