fix(intercom): fix date conversion from unix timestamp to js date of intercom attributes #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit fc1bb91 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (60% is the threshold). This pull request will bring the total coverage in the repository to 55.4%. View more on Code Climate. |
GuillaumeCisco
approved these changes
Jun 15, 2021
forest-bot
added a commit
that referenced
this pull request
Jun 15, 2021
## [8.7.2](v8.7.1...v8.7.2) (2021-06-15) ### Bug Fixes * **intercom:** fix date conversion from unix timestamp to js date of intercom attributes ([#742](#742)) ([97fa090](97fa090))
|
🎉 This PR is included in version 8.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Jun 16, 2021
# [9.0.0-beta.7](v9.0.0-beta.6...v9.0.0-beta.7) (2021-06-16) ### Bug Fixes * stats permissions should be retrieved only one time per team ([#741](#741)) ([8d05d75](8d05d75)) * **intercom:** fix date conversion from unix timestamp to js date of intercom attributes ([#742](#742)) ([97fa090](97fa090)) * prevent IP check from failing for the proxies including the port in the headers ([#738](#738)) ([810d0c1](810d0c1)) ### Features * include role in the user data inside the request ([#733](#733)) ([e74ce72](e74ce72))
|
🎉 This PR is included in version 9.0.0-beta.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
… action form (#742) BREAKING CHANGE: fields parameters on hook function is no longer a map of field, it is now an array. change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook.
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
# [8.0.0-beta.7](ForestAdmin/forest-express-sequelize@v8.0.0-beta.6...v8.0.0-beta.7) (2021-06-07) ### Features * **smart-action:** user can add dynamically field with hook on smart action form ([#742](ForestAdmin/forest-express-sequelize#742)) ([228bb42](ForestAdmin/forest-express-sequelize@228bb42)) ### BREAKING CHANGES * **smart-action:** fields parameters on hook function is no longer a map of field, it is now an array. change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook.
ShohanRahman
pushed a commit
that referenced
this pull request
Jan 25, 2022
# [8.0.0](ForestAdmin/forest-express-sequelize@v7.12.2...v8.0.0) (2021-07-19) ### Bug Fixes * abstractRecord type ([#772](ForestAdmin/forest-express-sequelize#772)) ([81492b9](ForestAdmin/forest-express-sequelize@81492b9)) * correctly get the IP address from the request headers ([2b5ed1d](ForestAdmin/forest-express-sequelize@2b5ed1d)) * fix types ([580ef41](ForestAdmin/forest-express-sequelize@580ef41)) ### Features * allow hooks for global and bulk smart action ([#769](ForestAdmin/forest-express-sequelize#769)) ([14c26cd](ForestAdmin/forest-express-sequelize@14c26cd)) * **browsing-context:** allow `Forest-Context-Url` header to give the current browser url of users ([#665](ForestAdmin/forest-express-sequelize#665)) ([c46fd66](ForestAdmin/forest-express-sequelize@c46fd66)) * **browsing-context:** allow `Forest-Context-Url` header to give the current browser url of users ([#665](ForestAdmin/forest-express-sequelize#665)) ([a61699a](ForestAdmin/forest-express-sequelize@a61699a)) * **security:** secure segments queries ([#764](ForestAdmin/forest-express-sequelize#764)) ([98d7f74](ForestAdmin/forest-express-sequelize@98d7f74)) * **smart-action:** user can add dynamically field with hook on smart action form ([#742](ForestAdmin/forest-express-sequelize#742)) ([228bb42](ForestAdmin/forest-express-sequelize@228bb42)) * feat(scopes)!: enforce scopes restrictions on a wider range of requests (#731) ([da7d71d](ForestAdmin/forest-express-sequelize@da7d71d)), closes [#731](ForestAdmin/forest-express-sequelize#731) ### BREAKING CHANGES * record is no longer send to the hook middleware & values option on smart action is no longer supported * **smart-action:** fields parameters on hook function is no longer a map of field, it is now an array. change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook. * the public API of forest-express has changed to include the parameters which are needed to evaluate scope filters. This includes PermissionMiddlewareCreator, all classes on the /exposed folder and most services. Many routes now require providing the current user timezone. * **browsing-context:** users willing to use this header needs either to clean the allowed headers or to add this specific header in the CORS configuration * **browsing-context:** users willing to use this header needs either to clean the allowed headers or to add this specific header in the CORS configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #640
Pull Request checklist: