Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smart-action): user can add dynamically field with hook on smart action form #742

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

arnaud-moncel
Copy link
Member

@arnaud-moncel arnaud-moncel commented Jun 7, 2021

BREAKING CHANGE: fields parameters on hook function is no longer a map of field, it is now an array.
change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook.

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

… action form

BREAKING CHANGE: fields parameters on hook function is no longer a map of field, it is now an array.
change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook.
@arnaud-moncel arnaud-moncel force-pushed the feat/dynamic-smart-action-field branch from 502d4e0 to 1ddff0b Compare June 7, 2021 13:05
Copy link
Member

@jeffladiray jeffladiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaud-moncel arnaud-moncel merged commit 228bb42 into beta Jun 7, 2021
@arnaud-moncel arnaud-moncel deleted the feat/dynamic-smart-action-field branch June 7, 2021 13:18
forest-bot added a commit that referenced this pull request Jun 7, 2021
# [8.0.0-beta.7](v8.0.0-beta.6...v8.0.0-beta.7) (2021-06-07)

### Features

* **smart-action:** user can add dynamically field with hook on smart action form ([#742](#742)) ([228bb42](228bb42))

### BREAKING CHANGES

* **smart-action:** fields parameters on hook function is no longer a map of field, it is now an array.
change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook.
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Jul 19, 2021
# [8.0.0](v7.12.2...v8.0.0) (2021-07-19)

### Bug Fixes

* abstractRecord type ([#772](#772)) ([81492b9](81492b9))
* correctly get the IP address from the request headers ([2b5ed1d](2b5ed1d))
* fix types ([580ef41](580ef41))

### Features

* allow hooks for global and bulk smart action ([#769](#769)) ([14c26cd](14c26cd))
* **browsing-context:** allow `Forest-Context-Url` header to give the current browser url of users ([#665](#665)) ([c46fd66](c46fd66))
* **browsing-context:** allow `Forest-Context-Url` header to give the current browser url of users ([#665](#665)) ([a61699a](a61699a))
* **security:** secure segments queries ([#764](#764)) ([98d7f74](98d7f74))
* **smart-action:** user can add dynamically field with hook on smart action form ([#742](#742)) ([228bb42](228bb42))

* feat(scopes)!: enforce scopes restrictions on a wider range of requests (#731) ([da7d71d](da7d71d)), closes [#731](#731)

### BREAKING CHANGES

* record is no longer send to the hook middleware & values option on smart action is no longer supported
* **smart-action:** fields parameters on hook function is no longer a map of field, it is now an array.
change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook.
* the public API of forest-express has changed to include the parameters which are needed to evaluate scope filters. This includes PermissionMiddlewareCreator, all classes on the /exposed folder and most services. Many routes now require providing the current user timezone.
* **browsing-context:** users willing to use this header needs either to clean the allowed headers or to add this specific header in the CORS configuration
* **browsing-context:** users willing to use this header needs either to clean the allowed headers or to add this specific header in the CORS configuration
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants