Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center type and method importation around Cecil #176

Merged
merged 3 commits into from
Aug 6, 2022

Conversation

kant2002
Copy link
Collaborator

@kant2002 kant2002 commented Aug 6, 2022

Reduce usage of typeof and Reflection across codebase
I did not change all usages, since some of them require factoring code differently, and it produce much more noise, and would be hard to review

Notes from F.:

Closes #161.

Reduce usage of `typeof` and Reflection across codebase
I did not change all usages, since some of them require factoring code differently, and it produce much more noise, and would be hard to review
@ForNeVeR ForNeVeR self-requested a review August 6, 2022 10:56
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but there's one small issue.

Cesium.CodeGen/Ir/Expressions/SubscriptingExpression.cs Outdated Show resolved Hide resolved
@kant2002 kant2002 requested a review from ForNeVeR August 6, 2022 11:19
@kant2002
Copy link
Collaborator Author

kant2002 commented Aug 6, 2022

I think I'm done here too.

@ForNeVeR ForNeVeR assigned ForNeVeR and unassigned kant2002 Aug 6, 2022
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit 24edd7f into ForNeVeR:main Aug 6, 2022
@kant2002 kant2002 deleted the kant/no-reflection branch September 29, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method lookup: get rid of reflection code
2 participants