Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method lookup: get rid of reflection code #161

Closed
Tracked by #80
ForNeVeR opened this issue Jul 30, 2022 · 0 comments · Fixed by #176
Closed
Tracked by #80

Method lookup: get rid of reflection code #161

ForNeVeR opened this issue Jul 30, 2022 · 0 comments · Fixed by #176
Labels
area:compiler Related to code compilation or type checking area:sdk Cesium .NET SDK good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request status:help-wanted Open for contributors

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Jul 30, 2022 •
edited
Loading

As of now, Cesium.CodeGen.Extensions.TypeSystemEx.MethodLookup does lookup on referenced assemblies using the runtime reflection. This means that to look up a method, Cesium has to load the referenced assembly.

This is not right, since not every assembly may even be loaded by the compiler (due to architecture or platform differences between the compiler runtime and the application target runtime).

We should inspect the referenced assemblies using Cecil instead of the runtime reflection

See also: // TODO[#161] in the compiler code.
@ForNeVeR ForNeVeR added kind:feature New feature or request status:help-wanted Open for contributors area:compiler Related to code compilation or type checking area:sdk Cesium .NET SDK good-first-issue An issue considered simple enough for new contributors labels Jul 30, 2022
This was referenced Jul 30, 2022
Closed
Merged
ForNeVeR added a commit to kant2002/Cesium that referenced this issue Aug 6, 2022
@ForNeVeR
(ForNeVeR#161) CodeGen: remove a comment since the issue is resolved
119960e
ForNeVeR added a commit that referenced this issue Aug 6, 2022
@ForNeVeR
(#161) CodeGen: remove a comment since the issue is resolved
24edd7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:compiler Related to code compilation or type checking area:sdk Cesium .NET SDK good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request status:help-wanted Open for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Center type and method importation around Cecil kant2002/Cesium
1 participant
@ForNeVeR