corrected paths, created directory and moved test files in the directory #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we'll wait with this PR. when Shkhiram publish his PR |
|
in the mean time should I start resolving travis-ci errors? @atherdon or move on with tests? |
|
i mentioned you at csv-parser repository:
https://github.com/GroceriStar/food-datasets-csv-parser find it
we all waiting for review from Vadim and merged PR from Shikhar. while it
was not done - we blocked
… |
|
@atherdon There is also this to PR merge |
|
sync your fork and move to tests file that was created today (related to
filesystem0
… |
|
i dont think that you made sync correctly. looks like you override changes made by @svr8 with your outdated code |
|
Code Climate has analyzed commit 80a58fe and detected 0 issues on this pull request. View more on Code Climate. |
atherdon
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the tests directory, moved test files, corrected paths for issue #137 and discussion at issue #132