Test coverage [discussion only]

[atherdon]

Is your feature request related to a problem? Please describe.
As most of our methods were created and perfect, i think it's a good time for cover them with tests, that will help us at our future work

@AndrewSerra let's discuss here what methods should be covered with tests

[AndrewSerra]

I think we should start with the ones that go in index.js Or we can do the exact opposite and start with small tests, so we are sure that all helper functions work and continue to the more important functions (such as the ones going to be in index.js)

[atherdon]

i love to go with small tests first. because we'll be able to split this task between few people.

…

[atherdon]

at this file i list our methods(maybe be outdated)
https://github.com/GroceriStar/food-static-files-generator/blob/master/readme3.md

[atherdon]

Now, when we'll merge PR from Shikhar, we'll have first basic tests related to methods from fileSystem.js

@AnuragKapoor-CSEngineer you can start to work on tests, related to methods, located at objects.js file

[AndrewSerra]

Are we creating a tests directory for this repo as well? Maybe we could have multiple files so we can categorize groups in separate files.

[atherdon]

I think it's a good idea to store tests at separated folder. can you create a separated task for it?

[AndrewSerra]

I think it's a good idea to store tests at separated folder. can you create a separated task for it?

Just to clarify, opening an issue to create the directory?

[atherdon]

yes, open issue to create a directory and move our current test files there and fix issues with paths :)

[AndrewSerra]

yes, open issue to create a directory and move our current test files there and fix issues with paths :)

Consider it done!

[atherdon]

@svr8 @amogh-jrules let's chat here about adding more tests to this package. right now we not starting it - i want to hear your thoughts

[atherdon]

#144

[svr8]

Writing tests for generateArray.js, generateFile.js and generateFiles.js seems relatively easy tasks to do. However, the core functions like the ones in fileSystem.js have been modified to use callbacks. So, first, I'll need to modify all of their calling methods to pass callback functions.

[atherdon]

i agree about callbacks for other methods. but not for all of them. can you create a separated task, where we can discuss it? I want to keep this task for tests discussion, but if we want to modify a few methods, that tests should be paused, while we not finish most of the work with code functions. I also plan to see how this module will work at 2 different places - and I assume something will go broken and we'll modify our code a bit. But yeah - most dirty work are completed

…

[atherdon]

I assume we need to add more coverage to methods like write, save, because i think we still can put not working code inside of our module and it wouldn't be noticed quickly.

just corrected a few issues, but it seems like we need to do it on a tests level

[0xamogh]

Hi, actually I dont have much experience writing unit tests. Im not sure what is the way to proceed, can anyone of you point me to some reading material or resources?

[atherdon]

This is why i want to get you some practice about it :) yeah, I have a cool collection of articles about Jest testing. https://github.com/ChickenKyiv/awesome-dev-stuff/blob/master/docs/jest/jest.md

…

[atherdon]

long but perfect book: https://flaviocopes.com/jest/

[atherdon]

@Beni03 @elnur004 I think you should join this project as well. Buzz me and i'll assing some simple tasks to you

[Beni03]

Yes, can you please assign a task for me

…

Sent from my iPhone

On Jul 14, 2019, at 10:51 AM, Arthur Tkachenko ***@***.***> wrote: @Beni03 @elnur004 I think you should join this project as well. Buzz me and i'll assing some simple tasks to you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[elnur004]

Of course. i'm waiting for a task

…

On Sun, 14 Jul 2019 at 21:51, Arthur Tkachenko ***@***.***> wrote: @Beni03 <https://github.com/Beni03> @elnur004 <https://github.com/elnur004> I think you should join this project as well. Buzz me and i'll assing some simple tasks to you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#132>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALH47MCQ53UICOJ34ZDCJ5TP7NRRZANCNFSM4IBSCSRA> .

[svr8]

Should we write tests for src/utils.js?

[atherdon]

@svr8 not sure. are we finish all pending things?