-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next #313
Open
SmartFinn
wants to merge
17
commits into
Foggalong:next
Choose a base branch
from
SmartFinn:next
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Next #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extendable code * No requires root permissions * Can get icon name from CSV file by application name * Better determining new icon name (from application name) * Fixes icons on a user desktop and hides backup files * Does not break shebang in launchers * Works with files that have spaces in the name
* remove text between parentheses
* icon_lookup: change local icons path * icon_lookup: return only the first match
* simplify show_menu * apply: clean up
SC2021: Don't use [] around ranges in tr, it replaces literal square brackets.
* added and changed several messages and comments * some functions and variable have been renamed * minor changes in code style and code refactoring
- get applications directories from XDG_DATA_DIR variable - recursive search for desktop files
* added --csv-file option * added --no-download option * deleted --force-download option * revert verb func name to verbose * minor visual changes
- fix the local at first (don't read the same file twice) - rename marker key - fix get_upstream_version - add clear command to show_menu
The command for quick testing: wget -qO- https://raw.githubusercontent.com/SmartFinn/hardcode-fixer/next/fix.sh | VERBOSE=1 bash |
Comparing the result of converting .desktop filename/app name to icon name -https://docs.google.com/spreadsheets/d/10kCgOZZMnlfBbLea29saV7fThUDwSYGsciRmyyhl-LQ/edit?usp=sharing I think converting from app name is more predictable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first stage of improvements to the next version hardcode-fixer.
There is a simple diagram that can help to understand how the script works dia.pdf.
Requires
Features
Extremely useful when executing via 'Run in Terminal' and through a pipe:
wget -qO- URL | bash
.# the commands in this example do the same hardcode-fixer -Av hardcode-fixer --apply --verbose hardcode-fixer apply -v
Limitations
ToDo
Icon=zotero.ico
, etc..)NOTE: This PR can be merged. The improvements in the list will be added in another.