Fix hardcoded apps

[bilelmoussaoui]

Fix #149
While checking hardcoded apps,and detecting the new icons the script will add automatically to a new csv file and use it when reverting to be sure that's the right file!
This will need some testing, if you find any issue i will fix it ;)

[krzysieki]

Thanks I confirm that this fixes #210 with no problems

[bilelmoussaoui]

@krzysieki Can you try to restore and see if old icon will be shown? or changing the theme to an other one and see if everything works fine in your case

[krzysieki]

I called command to revert: "fix.sh -r" but the old icon didn't show. And in ~/.local/share/applications/jetbrains-idea.desktop file there is a line "Icon=hardcoded".

[bilelmoussaoui]

In the same folder where you have the script. Is there any new csv file ? If so can you paste it here so i can see what's the problem:)

Le 14 déc. 2015 à 00:00, krzysieki [email protected] a écrit :

I called command to revert: "fix.sh -r" but the old icon didn't show. And in ~/.local/share/applications/jetbrains-idea.desktop file there is a line "Icon=hardcoded".

—
Reply to this email directly or view it on GitHub.

[bilelmoussaoui]

Should be fixed now 👍

[krzysieki]

Thanks for patch. "fix.sh -r" works now :)

Don't know If it is still needed, but the new csv file's content is:

Intellij IDE,jetbrains-idea,hardcoded,/home/krzysiek/.local/share/umake/ide/idea-ultimate/bin/idea.png,/home/krzysiek/.local/share/applications/
Visual Studio,visual-studio-code,hardcoded,/home/krzysiek/.local/share/umake/web/visual-studio-code/resources/app/resources/linux/vscode.png,/home/krzysiek/.local/share/applications/
Intellij IDE,jetbrains-idea,hardcoded,/home/krzysiek/.local/share/umake/ide/idea-ultimate/bin/idea.png,/home/krzysiek/.local/share/applications/
Visual Studio,visual-studio-code,hardcoded,/home/krzysiek/.local/share/umake/web/visual-studio-code/resources/app/resources/linux/vscode.png,/home/krzysiek/.local/share/applications/

[bilelmoussaoui]

@krzysieki Thanks! Can you revert again, and remove the csv file, and apply the patch again. And copy the new csv file content's 👍

[krzysieki]

New csv file contents:

Intellij IDE,jetbrains-idea,hardcoded,/home/krzysiek/.local/share/umake/ide/idea-ultimate/bin/idea.png,/home/krzysiek/.local/share/applications/
Visual Studio,visual-studio-code,hardcoded,/home/krzysiek/.local/share/umake/web/visual-studio-code/resources/app/resources/linux/vscode.png,/home/krzysiek/.local/share/applications/

Log after calling "./fix.sh"

L: Fixing Aptik...
L: Fixing HP Printer...
grep: hardcoded_apps.csv: No such file or directory
L: Fixing Intellij IDE...
L: Fixing Nvidia Settings...
L: Fixing Python (v2.7)...
L: Fixing Python (v3.4)...
L: Fixing Python (v3.5)...
L: Fixing Skype...
L: Fixing Ubuntu Web Browser...
L: Fixing Visual Studio...
L: Fixing X-Diagnose...

[bilelmoussaoui]

@krzysieki Thanks for testing this! Everything works fine. I pushed a new commit so you won't see this error grep: hardcoded_apps.csv: No such file or directory at all. What about when you change the icon theme to an other one after fixing the icons? the default icons are used?

[krzysieki]

Default icon for an unknown app is used. I assume this is correct bahavior?

[bilelmoussaoui]

@krzysieki Non, the default icons (the hardcoded ones) should be used. I forgot to copy those icons to icons folder. Should be fixed now, try to revert and apply again? :)

[bilelmoussaoui]

@Foggalong I did a lot of improvements on this today; I moved the backup code to a function that being called (the same code to backup an icon was repeated more than 3 times in the code); Tested this on my machine today and everything works just fine 👍 Do you think you will have some free time to test this ? :)