Local & Version Specific Not Fixed #149

vs0uz4 · 2015-08-17T13:48:35Z

after running sudo command ./fix.sh the same fixed several icons, with the exception of PhpStorm icon.

vs0uz4@vs0uz4-NTB:~/Code/hardcode-fixer$ sudo ./fix.sh
G: Fixing HP Printer...
G: Fixing Intel Graphics Installer...
G: Fixing Python (v2.7)...
G: Fixing Python (v3.4)...
G: Fixing Slingscold...
G: Fixing Valentina Studio...
G: Fixing YouTubeDL GUI...

result:

how to solve?

Foggalong · 2015-08-17T13:50:24Z

It's possible that we're missing your PHP storm. Can you find the launcher for PHP storm and give us:

the file name of the .desktop file
the icon line in the .desktop

vs0uz4 · 2015-08-17T14:03:04Z

name and location of .desktop file
/usr/share/applications/jetbrains-phpstorm.desktop

jetbrains-phpstorm.desktop content
[Desktop Entry]
Version=1.0
Type=Application
Name=PhpStorm
Icon=/home/vs0uz4/Downloads/PhpStorm/bin/webide.png
Exec="/home/vs0uz4/Downloads/PhpStorm/bin/phpstorm.sh" %f
Comment=Develop with pleasure!
Categories=Development;IDE;
Terminal=false
StartupWMClass=jetbrains-phpstorm

Foggalong · 2015-08-24T15:46:29Z

This is now fixed in the latest commit thanks to @bil-elmoussaoui :D

vs0uz4 · 2015-08-24T19:58:07Z

thank you, I'll do a "git pull" now!

bilelmoussaoui · 2015-08-24T19:58:41Z

@vs0uz4 already in the database ;)

vs0uz4 · 2015-08-24T22:44:58Z

not solved! I did git pull, and ran sudo ./fix.sh but PhpStorm icon continued in the same way!

bilelmoussaoui · 2015-08-25T15:28:20Z

Can you share the desktop file content after using the script? :) also if it's possible to check the phpstorm line in the tofix.csv after starting the script please

fii34 · 2015-08-26T14:13:10Z

I certify that the hardcoded not working in PHP Storm

PHP Storm,jetbrains-phpstorm,hardcoded,phpstorm

this does not work

jetbrains-phpstorm.desktop

[Desktop Entry]
Version=1.0
Type=Application
Name=PhpStorm
Icon=/home/qws/Загрузки/PhpStorm-141.2462/bin/webide.png
Exec="/home/qws/Загрузки/PhpStorm-141.2462/bin/phpstorm.sh" %f
Comment=Develop with pleasure!
Categories=Development;IDE;
Terminal=false
StartupWMClass=jetbrains-phpstorm

PHPStorm,jetbrains-phpstorm,hardcoded,phpstorm

this does not work

but it works on the script https://github.com/leoheck/hardcode-fixer

PHPStorm,jetbrains-phpstorm,$HOME/Загрузки/PhpStorm-141.2462/bin/webide.png,webide

PHPStorm,jetbrains-phpstorm,/home/${SUDO_USER:-$USER}/Загрузки/PhpStorm-141.2462/bin/webide.png,webide

I even thought that it is possible to register the most frequently used folders:

PHPStorm,jetbrains-phpstorm,/home/${SUDO_USER:-$USER}/Downloads/PhpStorm-141.2462/bin/webide.png,webide

PHPStorm,jetbrains-phpstorm,/home/${SUDO_USER:-$USER}/Desktop/PhpStorm-141.2462/bin/webide.png,webide

PHPStorm,jetbrains-phpstorm,$HOME/PhpStorm-141.2462/bin/webide.png,webide

However, any change in the version PhpStorm-141.2462 make these rules useless.
And in addition to the English language in the world full of others. All the rules are do not prescribe

You can see why hardcoded does not work?

And one more bug. During normal start of your script (sudo fix.sh) in the terminal I see dozens of entries like this:

mkdir: can not create directory «/home/qws/.local/share/icons/hicolor/scalable/apps/»: No such file or directory
mkdir: can not create directory «/home/qws/.local/share/icons/hicolor/scalable/apps/»: No such file or directory
mkdir: can not create directory «/home/qws/.local/share/icons/hicolor/scalable/apps/»: No such file or directory
mkdir: can not create directory «/home/qws/.local/share/icons/hicolor/scalable/apps/»: No such file or directory
mkdir: can not create directory «/home/qws/.local/share/icons/hicolor/scalable/apps/»: No such file or directory
mkdir: can not create directory «/home/qws/.local/share/icons/hicolor/scalable/apps/»: No such file or directory
mkdir: can not create directory

there is /home/qws/.local/share/icons/hicolor/ not scalable/apps

vs0uz4 · 2015-08-26T18:33:45Z

My phpstorm desktop content:

[Desktop Entry]
Version=1.0
Type=Application
Name=PhpStorm
Icon=/home/vs0uz4/Downloads/PhpStorm/bin/webide.png
Exec="/home/vs0uz4/Downloads/PhpStorm/bin/phpstorm.sh" %f
Comment=Develop with pleasure!
Categories=Development;IDE;
Terminal=false
StartupWMClass=jetbrains-phpstorm

My tofix.csv in script folder
PHP Storm,phpstorm,hardcoded,phpstorm
PHP Storm,jetbrains-phpstorm,hardcoded,phpstorm

my tofix.csv in /tmp folder
PHP Storm,phpstorm,hardcoded,phpstorm
PHP Storm,jetbrains-phpstorm,hardcoded,phpstorm

When you run the script error is generated
mkdir: It is impossible to create the directory "/home/vs0uz4/.local/share/icons/hicolor/scalable/apps/": File or directory not found
mkdir: It is impossible to create the directory "/home/vs0uz4/.local/share/icons/hicolor/scalable/apps/": File or directory not found
mkdir: It is impossible to create the directory "/home/vs0uz4/.local/share/icons/hicolor/scalable/apps/": File or directory not found
mkdir: It is impossible to create the directory "/home/vs0uz4/.local/share/icons/hicolor/scalable/apps/": File or directory not found
mkdir: It is impossible to create the directory "/home/vs0uz4/.local/share/icons/hicolor/scalable/apps/": File or directory not found

bilelmoussaoui · 2015-08-26T18:39:12Z

@Foggalong i think this is due to the force update of tofix.csv

vs0uz4 · 2015-08-26T18:40:55Z

I solved the error by adding the parameter "-p" to the mkdir command.

running the command:
mkdir -p /home/vs0uz4/.local/share/icons/hicolor/scalable/apps/

bilelmoussaoui · 2015-08-26T18:43:53Z

Well that does not solve the problem is just hide the error message , do you have this folder now? /home/vs0uz4/.local/share/icons/hicolor/scalable/apps/

vs0uz4 · 2015-08-26T18:53:28Z

-p, --parents "does not generate error if it already exists, create directories for parents as they are needed"

By using this command, he created the folders and soon after ran the script again when the error did not appear anymore.

bilelmoussaoui · 2015-08-26T18:54:40Z

I see, you can create a pull request to fix that ;)

vs0uz4 · 2015-08-26T19:35:09Z

pull request created!

fii34 · 2015-08-27T06:08:23Z

scalable/apps/ work, but the message is received - Sessions still open, not unmounting

PhpStorm not work, hardcoded not work.

bilelmoussaoui · 2015-08-27T06:55:13Z

I will check that this weekend

Le 27 août 2015 à 08:08, fii34 [email protected] a écrit :

scalable/apps/ work.
PhpStorm not work, hardcoded not work.

—
Reply to this email directly or view it on GitHub.

fii34 · 2015-08-27T08:16:52Z

I understand hardcoded trying to write new rules csv?
If you still work, you may need to give new rights to record?
Or write at all in another file csv (like a log)?

bilelmoussaoui · 2015-08-27T08:31:26Z

what i ve done is the easiest solution, i will try to understand whats not working ;)

Le 27 août 2015 à 10:16, fii34 [email protected] a écrit :

I understand hardcoded trying to write new rules csv?
If you still work, you may need to give new rights to record?
Or write at all in another file csv (like a log)?

—
Reply to this email directly or view it on GitHub.

Foggalong · 2015-08-27T12:59:15Z

I'm confused - is this issue now fixed? Is what @fii34 is talking about a new issue?

bilelmoussaoui · 2015-08-27T20:28:11Z

Not yet, I think that the hardcoded does not change to the icon path in the csv file. I will fix that this weekend ;)

Foggalong · 2015-08-27T20:29:17Z

Thanks :D

Foggalong · 2015-08-30T18:08:49Z

@vs0uz4 use your current version of the script to revert any changes made and then redownload and try again. It might be fixed now :)

vs0uz4 · 2015-08-30T20:46:07Z

I will test this now!

vs0uz4 · 2015-08-30T20:58:21Z

did the reversal, the timing between the github repositories, updating my fork.
Once again I ran sudo ./fix.sh and nothing happened.

my /usr/share/applications/jetbrains-phpstorm.desktop file content

[Desktop Entry]
Version=1.0
Type=Application
Name=PhpStorm
Icon=/home/vs0uz4/Downloads/PhpStorm/bin/webide.png
Exec="/home/vs0uz4/Downloads/PhpStorm/bin/phpstorm.sh" %f
Comment=Develop with pleasure!
Categories=Development;IDE;
Terminal=false
StartupWMClass=jetbrains-phpstorm

my ./local/share/applications folder content

my ./local/share/icons/hicolor folder content

my ./local/share/icons/scalable/apps folder content

my desktop with phpstorm icon default

Foggalong · 2015-09-02T16:12:44Z

@bil-elmoussaoui ?

bilelmoussaoui · 2015-09-02T19:46:30Z

@Foggalong Sorry i was a little bit busy those days. I will install Phpstorm and try to fix this right now

bilelmoussaoui · 2015-09-02T20:46:31Z

The issue is easy to fix ;) it's in the line 155

new_current=$(grep -Gq "Icon=*$" "$app_location$launcher")

the value of new current is always empty string; it's due to the regex; @Foggalong do you have any better regex to use in this case? :)

vs0uz4 · 2015-09-11T14:54:06Z

@Foggalong, @bil-elmoussaoui that way would not solve here?

*new_current = $ (grep -G "Icon = " "$ app_location $ launcher")

vs0uz4 · 2015-09-11T14:55:38Z

After debugging here, he spent no longer return emptiness. But still does not solve the problem bo fix. Should have more somewhere else in trouble.

bilelmoussaoui · 2015-09-11T19:30:49Z

Already fixed in my latest pull request

Le 11 sept. 2015 à 16:55, Vitor S Rodrigues [email protected] a écrit :

After debugging here, he spent no longer return emptiness. But still does not solve the problem bo fix. Should have more somewhere else in trouble.

—
Reply to this email directly or view it on GitHub.

vs0uz4 · 2015-09-13T12:07:24Z

OK! @bil-elmoussaoui thank you.
waiting to be done "merge"

bilelmoussaoui · 2015-10-23T18:54:51Z

@vs0uz4 can you check my latest pull request and test it in your case? i think everything will work fine after that! 💃

toby-1-kenobi · 2018-06-02T15:58:25Z

It's not working for RubyMine installed via Jetbrains Toolbox. Is this issue still not fixed?

My desktop entry has this line (even after running fix.sh):
Icon=/home/toby/.local/share/JetBrains/Toolbox/apps/RubyMine/ch-1/181.4203.562/.icon.svg

super-cooper · 2019-10-16T17:04:35Z

Reopening this thread because it appears to still not be working for me on Debian. All jetbrains software icons have not been fixed.

pauljsymonds · 2020-04-08T08:52:20Z

I'm running Debian 10.3 , KDE Plasma and latest Toolbox and this issue still exists.

What is the best workaround?

Foggalong self-assigned this Aug 17, 2015

Foggalong added the hardcoded app label Aug 17, 2015

Foggalong removed their assignment Aug 17, 2015

bilelmoussaoui mentioned this issue Aug 19, 2015

Fixes Gdebi issue and restore issue too #151

Merged

Foggalong closed this as completed Aug 24, 2015

Foggalong reopened this Aug 25, 2015

vs0uz4 mentioned this issue Aug 26, 2015

change fix.sh mkdir commands #161

Merged

bilelmoussaoui mentioned this issue Aug 27, 2015

Store home dir in a var #156

Closed

Foggalong added the bug label Aug 30, 2015

bilelmoussaoui mentioned this issue Sep 5, 2015

Fix hardcoded icons #167

Closed

bilelmoussaoui mentioned this issue Oct 15, 2015

Why system-wide fixing? #178

Open

bilelmoussaoui mentioned this issue Oct 23, 2015

Fix hardcoded apps #190

Closed

bilelmoussaoui mentioned this issue Dec 10, 2015

Does not work for Intellij Idea and Visual Studio Code #210

Closed

bilelmoussaoui mentioned this issue Jan 5, 2016

Icon for Android Studio numixproject/numix-core#2769

Closed

Foggalong mentioned this issue Jun 27, 2016

CLion and PyCharm #236

Closed

bilelmoussaoui mentioned this issue Nov 28, 2016

Fix Hardcoded icons #278

Closed

bilelmoussaoui mentioned this issue Jan 13, 2017

Icons of Jetbrains IDE installed using jetbrains toolbox not fixed #279

Closed

Foggalong mentioned this issue Sep 4, 2017

umake applications #288

Closed

Foggalong changed the title ~~Php Storm icon not fixed~~ Local & Version Specific Not Fixed Sep 4, 2017

Foggalong removed the hardcoded app label Sep 4, 2017

MarekAG mentioned this issue Sep 4, 2017

Icon name issue #285

Open

Local & Version Specific Not Fixed #149

Local & Version Specific Not Fixed #149

Comments

vs0uz4 commented Aug 17, 2015

Foggalong commented Aug 17, 2015

vs0uz4 commented Aug 17, 2015

Foggalong commented Aug 24, 2015

vs0uz4 commented Aug 24, 2015

bilelmoussaoui commented Aug 24, 2015

vs0uz4 commented Aug 24, 2015 • edited by Foggalong Loading

bilelmoussaoui commented Aug 25, 2015

fii34 commented Aug 26, 2015

vs0uz4 commented Aug 26, 2015

bilelmoussaoui commented Aug 26, 2015

vs0uz4 commented Aug 26, 2015

bilelmoussaoui commented Aug 26, 2015

vs0uz4 commented Aug 26, 2015

bilelmoussaoui commented Aug 26, 2015

vs0uz4 commented Aug 26, 2015

fii34 commented Aug 27, 2015

bilelmoussaoui commented Aug 27, 2015

fii34 commented Aug 27, 2015

bilelmoussaoui commented Aug 27, 2015

Foggalong commented Aug 27, 2015

bilelmoussaoui commented Aug 27, 2015

Foggalong commented Aug 27, 2015

Foggalong commented Aug 30, 2015

vs0uz4 commented Aug 30, 2015

vs0uz4 commented Aug 30, 2015

Foggalong commented Sep 2, 2015

bilelmoussaoui commented Sep 2, 2015

bilelmoussaoui commented Sep 2, 2015

vs0uz4 commented Sep 11, 2015

vs0uz4 commented Sep 11, 2015

bilelmoussaoui commented Sep 11, 2015

vs0uz4 commented Sep 13, 2015

bilelmoussaoui commented Oct 23, 2015

toby-1-kenobi commented Jun 2, 2018

super-cooper commented Oct 16, 2019 • edited Loading

pauljsymonds commented Apr 8, 2020

vs0uz4 commented Aug 24, 2015 •

edited by Foggalong

Loading

super-cooper commented Oct 16, 2019 •

edited

Loading