Support scatter for CUDA gradient #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Loos like |
This was referenced Jun 17, 2021
|
what's the blocker here? |
|
The gradient of scatter * and / for cuda need a cuda kernel. I wrote the cuda kernel and I am debugging it. It's almost there. |
yuehhua
force-pushed
the
scatter
branch
3 times, most recently
from
6a692dc to
5b53a86
Compare
add count_indices for cuarray add CUDA kernel for divide_by_counts! add NNlib.∇scatter_src for cuda gradient support scatter mean AD for CUDA support scatter *,/ AD for CUDA
|
Finally!! |
yuehhua
commented
Jul 1, 2021
| # multiply all values to be aggregated but not itself | ||
| x = one(T) | ||
| for k in inds | ||
| jk = Base._to_linear_index(src, Tuple(cart_j)..., Tuple(k)...) |
There was a problem hiding this comment.
Base._to_linear_index is introduced here to transform index of any form into integer index. Integer index is required to index a cuarray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.