Merge NNlibCUDA as subpackage #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TagBot and CompatHelper
Add a License
Co-authored-by: Dhairya Gandhi <[email protected]>
Fix use of convdims.
save allocs during algorithm search
* print/convert batchedadjtrans over cuarray * Update test/batchedadjtrans.jl Co-authored-by: Brian Chen <[email protected]> Co-authored-by: Brian Chen <[email protected]>
Missing Identity Activation Import
1.7 nightly no longer exists and was causing errors. Also updated to 1.8 to match configuration across the org.
…opj-fold HPC merge.
Co-authored-by: Brian Chen <[email protected]>
added fold/unfold and gpu tests
Updates for CUDA.jl 4.
| agents: | ||
| queue: "juliagpu" | ||
| cuda: "*" | ||
| timeout_in_minutes: 60 |
There was a problem hiding this comment.
not blocking for this PR, cleanup can be done later, but subpackages' .buildkite and .github dirs should be removed?
CarloLucibello
approved these changes
Feb 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the process of turning NNlibCUDA into a package extension, we need to first move the source into this repo while preserving its history. Without doing so, we wouldn't be able to re-register it as a subpackage. To that end, I've followed the procedure described in JuliaPlots/Plots.jl#4419 (comment) to place it under
ext/NNlibCUDA. Once this is done and registered, #445 can be redone on top of this foundation.PR Checklist