Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softplus #59

Merged
merged 1 commit into from
Mar 26, 2019
Merged

softplus #59

merged 1 commit into from
Mar 26, 2019

Conversation

pevnak
Copy link
Contributor

@pevnak pevnak commented Jul 30, 2018

There is an overflow in softplus, so I have fixed it. I might done the pull-request incorrectly. But if someone (Mike) can cut&paste, including test, it would be excellent.

@MikeInnes MikeInnes force-pushed the pull-request/ea057b05 branch from ea057b0 to bdf167d Compare March 26, 2019 13:08
@codecov-io
Copy link

Codecov Report

Merging #59 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   68.61%   68.46%   -0.16%     
==========================================
  Files           9        9              
  Lines         666      666              
==========================================
- Hits          457      456       -1     
- Misses        209      210       +1
Impacted Files Coverage Δ
src/activation.jl 80% <ø> (ø) ⬆️
src/impl/pool.jl 46.58% <0%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d07ac0b...bdf167d. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #59 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   68.61%   68.46%   -0.16%     
==========================================
  Files           9        9              
  Lines         666      666              
==========================================
- Hits          457      456       -1     
- Misses        209      210       +1
Impacted Files Coverage Δ
src/activation.jl 80% <ø> (ø) ⬆️
src/impl/pool.jl 46.58% <0%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d07ac0b...bdf167d. Read the comment docs.

@MikeInnes MikeInnes merged commit 2bd7e8a into FluxML:master Mar 26, 2019
@MikeInnes
Copy link
Member

Easy enough to trim away the bad commits. Thanks @pevnak!

ToucheSir added a commit that referenced this pull request Feb 13, 2023
added fold/unfold and gpu tests
ToucheSir added a commit that referenced this pull request Feb 13, 2023
added fold/unfold and gpu tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants