Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App icon detailed documentation #1384

Merged
merged 3 commits into from
Oct 12, 2024
Merged

App icon detailed documentation #1384

merged 3 commits into from
Oct 12, 2024

Conversation

gayanSandamal
Copy link
Contributor

Description

Screenshot 2024-10-11 at 14 58 08

@joepavitt let me if you think the screenshots are too much

Screenshot 2024-10-11 at 14 59 01

Related Issue(s)

#1144 (Configurable PWA Icon)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gayanSandamal gayanSandamal self-assigned this Oct 11, 2024
@joepavitt
Copy link
Collaborator

They're okay, but maybe make them smaller and centrally align them to the page

@joepavitt
Copy link
Collaborator

You've also mentioned it requires a URL, does this not work with a local file URI?

@gayanSandamal
Copy link
Contributor Author

They're okay, but maybe make them smaller and centrally align them to the page

Sure, I will update

You've also mentioned it requires a URL, does this not work with a local file URI?

This doesn't require an external URL, we can also add the image to FFC assets and refer from there

@gayanSandamal
Copy link
Contributor Author

@joepavitt I've updated image sizes and alignments

Screenshot 2024-10-11 at 17 38 01

@joepavitt
Copy link
Collaborator

Thanks Gayan, one of the images I've removed, as wasn't sure it was necessary, and just improved the captions a little, but otherwise. Looking great.

@joepavitt joepavitt merged commit ba08995 into main Oct 12, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the Docs--App-Icon-detailed branch October 12, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants