Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Application Icon #1144

Closed
3 tasks done
joepavitt opened this issue Jul 30, 2024 · 2 comments · Fixed by #1377
Closed
3 tasks done

Configurable Application Icon #1144

joepavitt opened this issue Jul 30, 2024 · 2 comments · Fixed by #1377
Assignees
@gayanSandamal
Labels
feature-request New feature or request that needs to be turned into Epic/Story details size:M - 3 Sizing estimation point

Comments

@joepavitt
Copy link
Collaborator

joepavitt commented Jul 30, 2024 •
edited
Loading

Description

Currently, the PWA icon is compiled when we distribute the npm package, meaning that users are not able to override this with their own preferences/icon.

We should offer configuration options by which users can tailor the icon to their specific application

Here is an example of a dynamically served manifest.json: https://stackoverflow.com/questions/50086761/dynamic-icon-pwa-manifest

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

Tasks
Preview Give feedback
  1. Allow user configuration of application's icon #1326
    size:XS - 1
    gayanSandamal
  2. Configurable Browser Tab Icon #1327
    size:XS - 1
    gayanSandamal
  3. Configurable PWA Icon #1328
    size:M - 3
    gayanSandamal
@joepavitt joepavitt added size:M - 3 Sizing estimation point needs-triage Needs looking at to decide what to do feature-request New feature or request that needs to be turned into Epic/Story details labels Jul 30, 2024
@joepavitt joepavitt removed the needs-triage Needs looking at to decide what to do label Jul 30, 2024
@joepavitt
Copy link
Collaborator Author

The other thing this can cover is the icon showing in the Browser tab, which is currently the Dashboard icon

@joepavitt joepavitt moved this to In Progress in 🛠 Development Aug 31, 2024
@joepavitt
Copy link
Collaborator Author

First Iteration:

  • Option for the ui-base to have an "Icon" field
  • When set to a given file, that shows as the icon for the Dashboard in the browser

@joepavitt joepavitt changed the title Configurable PWA Icon Configurable Application Icon Sep 25, 2024
This was referenced Sep 26, 2024
Merged
Closed
This was referenced Oct 7, 2024
Merged
Merged
@gayanSandamal gayanSandamal linked a pull request Oct 10, 2024 that will close this issue
Add configurable app icon #1377
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🛠 Development Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Under Review to Done in Dashboard Backlog Oct 10, 2024
@gayanSandamal gayanSandamal mentioned this issue Oct 11, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gayanSandamal gayanSandamal

Labels
feature-request New feature or request that needs to be turned into Epic/Story details size:M - 3 Sizing estimation point
Projects
Dashboard Backlog
Status: Done
🛠 Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add configurable app icon FlowFuse/node-red-dashboard
2 participants
@gayanSandamal @joepavitt