Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable app icon #1377

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Add configurable app icon #1377

merged 9 commits into from
Oct 10, 2024

Conversation

gayanSandamal
Copy link
Contributor

@gayanSandamal gayanSandamal commented Oct 10, 2024 •
edited
Loading

Description

Configurable app icon support.

This contains below PRs

  1. Added app icon field to ui base - Added app icon field to ui base #1334
  2. Override favicon if the app icon is available - Override favicon if the app icon is available #1335
  3. Customizable PWA icon support - Customizable PWA icon support #1366

Related Issue(s)

#1144

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gayanSandamal gayanSandamal linked an issue Oct 10, 2024 that may be closed by this pull request
Configurable Application Icon #1144
Closed
@gayanSandamal gayanSandamal self-assigned this Oct 10, 2024
Steve-Mcl
Steve-Mcl approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a feature branch and all 3 PRs were approved, i will approve this one on that regard - but I am requesting a local demo before release :)

@gayanSandamal gayanSandamal merged commit bbe5ba2 into main Oct 10, 2024
1 of 2 checks passed
@gayanSandamal gayanSandamal deleted the 1144-configurable-pwa-icon branch October 10, 2024 10:45
@gayanSandamal gayanSandamal changed the title 1144 configurable pwa icon Add configurable app icon Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees

@gayanSandamal gayanSandamal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable Application Icon
3 participants
@gayanSandamal @Steve-Mcl @joepavitt