Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading 3rd party widgets #1286

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Loading 3rd party widgets #1286

merged 3 commits into from
Sep 14, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Sep 11, 2024 •
edited
Loading

Description

  • Refactors 3rd party widgets loading to support locations that Node-RED already supports
    • main package.json
    • user package.json
    • userNodes locations
  • Adds unit tests and fixtures

Tests

REF: https://github.com/FlowFuse/node-red-dashboard/actions/runs/10814674509/job/30001697116?pr=1286#step:6:17

  utils
    getThirdPartyWidgets
      ✔ should load single node package
      ✔ should load nodes from a package dependencies

Demo Screenshots

Src showing code finds 3 packages in different locations

image

Actual running

image

This PR supersedes #1274

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from joepavitt September 11, 2024 15:21
@Steve-Mcl Steve-Mcl mentioned this pull request Sep 11, 2024
Closed
10 tasks
Steve-Mcl
Steve-Mcl commented Sep 11, 2024
View reviewed changes
nodes/utils/index.js Outdated Show resolved Hide resolved
@joepavitt joepavitt merged commit e7771c1 into main Sep 14, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the contrib-node-sources branch September 14, 2024 10:54
@Steve-Mcl Steve-Mcl mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherwillembotha theotherwillembotha theotherwillembotha left review comments

@joepavitt joepavitt joepavitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steve-Mcl @theotherwillembotha @joepavitt