Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A node red restart is necessary after installing third party ui nodes #938

Closed
colinl opened this issue Jun 2, 2024 · 7 comments · Fixed by #1316
Closed

A node red restart is necessary after installing third party ui nodes #938

colinl opened this issue Jun 2, 2024 · 7 comments · Fixed by #1316
Assignees
Labels
bug Something isn't working size:L - 5 Sizing estimation point

Comments

@colinl
Copy link
Contributor

colinl commented Jun 2, 2024

Current Behavior

If a non-core node such as @flowfuse/node-red-dashboard-2-ui-led is installed then it is necessary to restart node-red in order for the widget to appear on the dashboard. Before the restart the widget appears just as an empty space on the page. It seems that this is also the case for ui-frame and ui-gauge-classic.

Expected Behavior

Either a restart should not be required, or the user should be informed that a restart is required.

Steps To Reproduce

No response

Environment

  • Dashboard version: 1.11.1
  • Node-RED version: 4.0.0 beta 4
  • Node.js version: 20.5.1
  • npm version:
  • Platform/OS:
  • Browser: Edge

Have you provided an initial effort estimate for this issue?

I am not a FlowFuse team member

@colinl colinl added bug Something isn't working needs-triage Needs looking at to decide what to do labels Jun 2, 2024
@joepavitt joepavitt moved this from Backlog to Up Next in Dashboard Backlog Jun 12, 2024
@joepavitt joepavitt added the size:L - 5 Sizing estimation point label Jun 12, 2024
@joepavitt
Copy link
Collaborator

This is something I want to prioritise, as it's very annoying, but will require a re-think on how we load up our third-party plugins

@Paul-Reed
Copy link
Contributor

Still occurring... just imported @hotnipi/node-red-dashboard-2-ui-gauge-linear and which did not load.
Chrome's developer console showed -

error

A node-RED restart was required for the node to load.
https://discourse.nodered.org/t/good-bye-ui-level-hello-gauge-linear/91144/2

Node-RED v4.0.1
Dashboard 2 v1.17.0)

@joepavitt
Copy link
Collaborator

Thanks Paul, this requires a quite significant overhaul on our build pipeline and server-side architecture, which we've not entirely got on top of yet.

@Steve-Mcl Steve-Mcl self-assigned this Sep 20, 2024
@Steve-Mcl
Copy link
Contributor

I am hoping the refactoring I did in #1286 will permit us to get past this?

In theory: we listen for node-red event "type-registered" (RED.event.on('type-registered', type)), see if it is a dashboard nodes, re-run (or check and compare) the new code in #1286

completely untested but worth a look see.

@joepavitt
Copy link
Collaborator

@Steve-Mcl Paul did mention he is running 1.17.0, and from what I can tell, that should be included in that release

@Paul-Reed
Copy link
Contributor

It does seem repeatable;

  • Uninstall the node
  • Restart node-RED
  • Install the node again

Same result

@Steve-Mcl
Copy link
Contributor

@Steve-Mcl Paul did mention he is running 1.17.0, and from what I can tell, that should be included in that release

The work in that pr was groundwork. I was noting it as a memory aid for when I get on to this issue (I didn't mean to imply it was already solved - sorry guys )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:L - 5 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants