-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2566 Add email signature support #2634
Conversation
Hi @ioanmo226, let's temporarily disable UI tests, because of their instability and quite random results. |
I agree but we might miss some issues if we disable UI tests. |
For sure, we'll run all tests before new release, but while working on the remaining features it'll be ok to skip tests and work on failing tests (if there will be any) after fixing CI. As these failing attempts take quite long time, and in November we've already spent almost half of our previous month iOS CI budget. |
Ok, I agree |
@sosnovsky Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR added email signature support
close #2566 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):