Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email signatures support #2566

Closed
sosnovsky opened this issue May 9, 2024 · 0 comments · Fixed by #2634
Closed

Add email signatures support #2566

sosnovsky opened this issue May 9, 2024 · 0 comments · Fixed by #2634
Assignees
@ioanmo226
Labels
actionable
Milestone
1.3.1

Comments

@sosnovsky
Copy link
Collaborator

It should work the same as in browser extension:

  • signatures are fetched from settings.sendAs.list
  • html is converted to plain text
  • signature text is added to message textbox when composing email message

related android issue - FlowCrypt/flowcrypt-android#2712
@ioanmo226 ioanmo226 mentioned this issue Oct 7, 2024
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Nov 7, 2024
@ioanmo226
#2566 Add email signature support (#2634)
31c7e8d 
* wip

* fix: remove html tags

* fix: signature change

* feat: added ui test

* fix: sender

* fix: ui test

* temp: increase timeout

* temp: incvrease timeout

* Revert "temp: incvrease timeout"

This reverts commit b9395bd.

* Revert "temp: increase timeout"

This reverts commit 333b342.

* fix: temporarilly disable ui tests

* fix: semaphoreci

* fix: semaphoreci

* fix: pr reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioanmo226 ioanmo226

Labels
actionable
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

#2566 Add email signature support FlowCrypt/flowcrypt-ios
2 participants
@sosnovsky @ioanmo226