-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2396 Fix: choose correct keys for message encryption #2413
#2396 Fix: choose correct keys for message encryption #2413
Conversation
FlowCrypt/Functionality/Services/Compose Message Helper/ComposeMessageHelper.swift
Outdated
Show resolved
Hide resolved
the title should say "correct keys" not "correct key". hopefully the implementation reflects that, didn't check |
I also think it'll be useful to have ability to send unencrypted message to recipient without valid keys, but it'll be for another issue. For example, user tries to send message to recipient with expired key (or sign-only key) - currently we just show modal saying Here we can add button
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now 👍 Let's just rename some variables to be consistent
FlowCrypt/Controllers/Compose/Extensions/ComposeViewController+ActionHandling.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Controllers/Compose/Extensions/ComposeViewController+ActionHandling.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Compose Message Helper/ComposeMessageError.swift
Outdated
Show resolved
Hide resolved
…f github.com:FlowCrypt/flowcrypt-ios into 2396-fix-choosing-correct-key-for-message-encryption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR fixed choosing correct key for message encryption
close #2396 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):