Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2396 Fix: choose correct keys for message encryption #2413

Merged

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Oct 26, 2023

This PR fixed choosing correct key for message encryption

close #2396 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review October 26, 2023 15:12
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner October 26, 2023 15:12
@tomholub
Copy link
Collaborator

the title should say "correct keys" not "correct key". hopefully the implementation reflects that, didn't check

@ioanmo226 ioanmo226 changed the title #2396 Fix: choose correct key for message encryption #2396 Fix: choose correct keys for message encryption Oct 30, 2023
@sosnovsky
Copy link
Collaborator

I also think it'll be useful to have ability to send unencrypted message to recipient without valid keys, but it'll be for another issue.

For example, user tries to send message to recipient with expired key (or sign-only key) - currently we just show modal saying recipient has expired key, please contact him. But to message this recipient user will need to use another email client.

Here we can add button Send unencrypted message to error modal, tapping on it will open another compose screen with predefined text:

Hi,

I tried to compose encrypted message to you, but your public key is expired|revoked|sign-only.
Can you please share your valid public key.

Thanks

@ioanmo226 ioanmo226 requested a review from sosnovsky October 31, 2023 11:09
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now 👍 Let's just rename some variables to be consistent

…f github.com:FlowCrypt/flowcrypt-ios into 2396-fix-choosing-correct-key-for-message-encryption
@ioanmo226 ioanmo226 requested a review from sosnovsky October 31, 2023 15:28
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit 914a16e into master Oct 31, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 2396-fix-choosing-correct-key-for-message-encryption branch October 31, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix choosing correct key for message encryption
3 participants