Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to message recipient without valid public key #2421

Closed
sosnovsky opened this issue Oct 30, 2023 · 3 comments · Fixed by #2429
Closed

Add ability to message recipient without valid public key #2421

sosnovsky opened this issue Oct 30, 2023 · 3 comments · Fixed by #2429
Assignees
@ioanmo226
Labels
actionable
Milestone
1.3.0: Maintenance

Comments

@sosnovsky
Copy link
Collaborator 

          I also think it'll be useful to have ability to send unencrypted message to recipient without valid keys, but it'll be for another issue.

For example, user tries to send message to recipient with expired key (or sign-only key) - currently we just show modal saying recipient has expired key, please contact him. But to message this recipient user will need to use another email client.

Here we can add button Send unencrypted message to error modal, tapping on it will open another compose screen with predefined text:

Hi,

I tried to compose encrypted message to you, but your public key is expired|revoked|sign-only.
Can you please share your valid public key.

Thanks

Originally posted by @sosnovsky in #2413 (comment)
@tomholub
Copy link
Collaborator

could be treated like no keys, after the error, offer password message or plain

@ioanmo226
Copy link
Collaborator

@sosnovsky Is this also 1.3.0 milestone?

@sosnovsky
Copy link
Collaborator Author

Yes, let's include it in 1.3.0

@sosnovsky sosnovsky added this to the 1.3.0: Maintenance milestone Nov 1, 2023
@ioanmo226 ioanmo226 mentioned this issue Nov 8, 2023
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Nov 14, 2023
@ioanmo226
#2421 feat: added ability to message recipient without valid public k…
f8d7f1a 
…ey (#2429)

* feat: added ability to message recipient without valid public key

* fix: password message

* fix: pr reviews and ui test

* fix: ui test

* fix: ui test

* fix: ui test

* fix: ui test

* fix: ui test

* fix: ui test

* fix: pr reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioanmo226 ioanmo226

Labels
actionable
Projects
None yet
Milestone
1.3.0: Maintenance
Development

Successfully merging a pull request may close this issue.

#2421 feat: added ability to message recipient without valid public key FlowCrypt/flowcrypt-ios
3 participants
@sosnovsky @tomholub @ioanmo226