Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1086 Added multiline support to signature badge #2377

Merged

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 25, 2023

This PR added multiline support to signature badge

close #1086 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

image
image


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review September 26, 2023 06:18
@ioanmo226 ioanmo226 requested a review from sosnovsky September 26, 2023 11:19
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sosnovsky sosnovsky enabled auto-merge (squash) September 26, 2023 12:28
@sosnovsky sosnovsky merged commit 4ad0dd8 into master Sep 26, 2023
@sosnovsky sosnovsky deleted the 1086-ui-encryptionsignature-badges-to-support-multiline branch September 26, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - encryption/signature badges to support multiline
2 participants