Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - encryption/signature badges to support multiline #1086

Closed
tomholub opened this issue Nov 24, 2021 · 10 comments · Fixed by #2377
Closed

UI - encryption/signature badges to support multiline #1086

tomholub opened this issue Nov 24, 2021 · 10 comments · Fixed by #2377
Assignees

Comments

@tomholub
Copy link
Collaborator

Got this for FlowCrypt/flowcrypt-ios/Core/source/assets/compat/mime-email-plain-signed-detached.txt. Signature error looks too long.

The error is not necessarily too long, but he visual should be fixed so that the badge flows on multiple lines. I'll file a separate issue for that.

Originally posted by @tomholub in #1020 (comment)

@tomholub
Copy link
Collaborator Author

image

@tomholub tomholub changed the title encryption/signature badges to support multiline UI - encryption/signature badges to support multiline Nov 24, 2021
@DenBond7
Copy link
Collaborator

DenBond7 commented Dec 7, 2021

@tomholub Maybe it will be better just to show can't verify signature. After that, a user can click on that badge and we will show a dialog with the details. If the text will be really big the UI will look a little ugly.

One more thing - I think we can do all these badges clickable. And show details after clicking on them.

For example:

encrypted -> this message was encrypted for AB...OF and BB...RH fingerprints
not encrypted -> it's a regular message. Not protected.
signed -> signed by AB...OF

and so on...

Like Thunderbird does it

image

@tomholub
Copy link
Collaborator Author

tomholub commented Dec 7, 2021

Yes, I suppose we could do that.

@tomholub
Copy link
Collaborator Author

tomholub commented Dec 7, 2021

When tapped, it could produce a modal with more details, which is simple enough to do in code.

@ioanmo226 ioanmo226 self-assigned this May 26, 2022
@tomholub
Copy link
Collaborator Author

@ioanmo226 I've just assigned you a few :-) I want to still think more about this one

@ioanmo226
Copy link
Collaborator

ok

@ioanmo226
Copy link
Collaborator

@tomholub Have you decided yet?
@sosnovsky Could you answer in case Tom is busy?

@sosnovsky
Copy link
Collaborator

I think we can use our existing block with message details for showing signature verification errors:

Screenshot 2023-09-18 at 22 15 49

So badge will show just cannot verify signature text, while no public key ... for email ... text will go to the bottom of message details block. And this block should become visible after tapping on signature badge (currently it's shown only after tap on message recipients).

@ioanmo226 what do you think about such solution?

@ioanmo226
Copy link
Collaborator

Sounds good!

@ioanmo226
Copy link
Collaborator

Simplest solution for above issue

sosnovsky pushed a commit that referenced this issue Sep 26, 2023
* fix: added signature badge support for multiline

* fix: pr reviews

* fix: string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants