-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO_MDC (not integrity protected) message produces empty screen #1144
Comments
@martgil can you confirm we have a message like this on e2e account and you can reproduce it there? |
Hi @tomholub, Yes sir, the message is also included on the e2e account. The same happens for the e2e account - with the latest ios build. |
Co-authored-by: Dmitry Sotnikov <[email protected]>
There's a test added in #1154 that needs to also be updated once fixed |
@tomholub |
We should render the error into the message body just like we do for other decrypt errors - no modals. See related #1143 - we don't want a modal here (except for collecting pass phrase), we want to render the error into the body. And set badge to "decrypt error" in both cases. |
@tomholub |
Here I get this - |
If that's true, then key_mismatch should be showing a key_mismatch error, not empty result. Should compare the behavior to Android app and browser extension, for that message. |
OK, so this one is not about MDC? |
Check how browser extension and Android app renders it and paste screenshots here, then we'll be wiser. |
That's not what I'm seeing. You are missing a key which I added to EKM a week ago. For now the apps don't support ongoing sync of private keys, so you need to reset the extension and go through setup again. FlowCrypt Settings -> switch to e2e account on top right -> Additional Settings (notice there is just one key) -> Experimental -> scroll down -> reset on the bottom Then go through setup of e2e account again. This time it should load two keys. Then view the message again. You should see this: Then log out from e2e account on iOS, go through setup there, and continue debugging on iOS. |
@tomholub |
Yes, it's ok to add this one. Thanks for asking. |
I can reproduce MDC error only using this configuration:
output:
But in code for this key we use first longid as primary:
in code:
I guess this is the reason why we get |
@tomholub |
I'll have to take a look myself. You can move onto another issue until I have some feedback. |
Please make a draft PR if you wrote a new test that can be debugged. Thanks! |
* Draft unit test for integrity check * updated tests * fix rendering blockParseErr * fix no-mdc error * fix attachment with mismatch key * simplify * rename test * fix * PR comments Co-authored-by: tomholub <[email protected]> Co-authored-by: Roma Sosnovsky <[email protected]>
@tomholub, I have retested the latest master branch and there is only one that is not working properly at the moment.
This message has no description at all, where it should be flagged as NO_MDC - Missing integrity checks
Originally posted by @martgil in #704 (comment)
The text was updated successfully, but these errors were encountered: