Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected modal for some key mismatch situations #1143

Closed
tomholub opened this issue Dec 2, 2021 · 2 comments · Fixed by #1219
Closed

unexpected modal for some key mismatch situations #1143

tomholub opened this issue Dec 2, 2021 · 2 comments · Fixed by #1219
Assignees

Comments

@tomholub
Copy link
Collaborator

tomholub commented Dec 2, 2021

Hi @tomholub,

I just noticed that the first key mismatch reported above was actually an error for a public key mismatch (I think)

In case you are wondering, here is what it looks like for mismatch (private key) which might be related to #1140
image

Originally posted by @martgil in #704 (comment)

There is no difference between a public key mismatch and a private key mismatch - it's always a mismatch between a public key that encrypted the message and private key that is trying to open it. It's always both.

So there is something else going on. Could you please copy this message into e2e account and reproduce it there? But please use subject key mismatch unexpectedly produces a modal

@tomholub tomholub added this to the 0.6.0: Maintenance milestone Dec 2, 2021
@tomholub tomholub changed the title unexpecged modal for some key mismatch situations unexpected modal for some key mismatch situations Dec 2, 2021
@martgil
Copy link
Collaborator

martgil commented Dec 3, 2021

There is no difference between a public key mismatch and a private key mismatch - it's always a mismatch between a public key that encrypted the message and private key that is trying to open it. It's always both.

Thank you, sir! I understand it clearly now.

I have moved the message with an appropriate subject on e2e account and I'm getting the same results.
Screen Shot 2021-12-03 at 12 30 20 PM

@tomholub tomholub assigned ivan-ushakov and unassigned martgil Dec 3, 2021
@tomholub
Copy link
Collaborator Author

tomholub commented Dec 3, 2021

Thanks. Instead of the modal, it should render the key mismatch like we're already usually rendering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants