Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4282 fix: duplicated contact search result #4944

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Feb 8, 2023

This PR fixed duplicated contact search result

close #4282 // if this PR closes an issue


Tests (delete all except exactly one):

  • Test updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's also update ui test compose - can load contact based on name to ensure that search results list contains only 1 contact

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky enabled auto-merge (squash) February 8, 2023 13:20
@sosnovsky sosnovsky merged commit d1b6613 into master Feb 8, 2023
@sosnovsky sosnovsky deleted the feature/issue-4282 branch February 8, 2023 13:28
FlowCryptRobot pushed a commit that referenced this pull request Feb 22, 2023
…#4943)

* build(deps-dev): bump @openpgp/web-stream-tools from 0.0.11 to 0.0.13

Bumps [@openpgp/web-stream-tools](https://github.com/openpgpjs/web-stream-tools) from 0.0.11 to 0.0.13.
- [Release notes](https://github.com/openpgpjs/web-stream-tools/releases)
- [Commits](openpgpjs/web-stream-tools@v0.0.11...v0.0.13)

---
updated-dependencies:
- dependency-name: "@openpgp/web-stream-tools"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* #4282 fix: duplicated contact search result (#4944)

* fix: dupliated contact search result

* feat: added ui test

* fix: pr review

* #4940 Update build script to not produce .bak files (#4945)

* update build script

* rename STREAMS_OUTDIR to STREAMS_FILES

* #4844 feat: renew id token when expires (#4949)

* feat: renew id token when expires

* fix: pr reviews

* Employ user verification mechanisms from OpenPGP v5 (#4946)

* reuse getPrimeryUser method

* verifying key users

* allow localhost domain for email address

* fix

* fix and test

* use verified users in key-import-ui

* PR review fixes

---------

Co-authored-by: Roman Shevchenko <[email protected]>

* prevent pasting large input on secure compose (#4914)

* prevent pasting large input on secure compose

* Added type definition for SquireEditor.getRoot()

* apply requested change

* update

* cleanup

* update

* consider selection

* add warning modal

* update

* update

* update

---------

Co-authored-by: Roman Shevchenko <[email protected]>
Co-authored-by: Roman Shevchenko <[email protected]>

* fix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ioan Moldovan <[email protected]>
Co-authored-by: Roma Sosnovsky <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman Shevchenko <[email protected]>
Co-authored-by: Mart G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate contact search result
2 participants