Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trouble building the extension #4940

Closed
tomholub opened this issue Feb 7, 2023 · 2 comments · Fixed by #4941 or #4945
Closed

trouble building the extension #4940

tomholub opened this issue Feb 7, 2023 · 2 comments · Fixed by #4941 or #4945
Assignees
@sosnovsky
Labels
in progress
Milestone
8.4.3: Use shared...

Comments

@tomholub
Copy link
Collaborator

tomholub commented Feb 7, 2023

@rrrooommmaaa I tried to build extension with npm run build from master branch, but it fails with error after this merge

+ mkdir -p ./build/generic-extension-wip/lib/streams
+ cp node_modules/@openpgp/web-stream-tools/lib/node-conversions.js node_modules/@openpgp/web-stream-tools/lib/reader.js node_modules/@openpgp/web-stream-tools/lib/streams.js node_modules/@openpgp/web-stream-tools/lib/util.js node_modules/@openpgp/web-stream-tools/lib/writer.js ./build/generic-extension-wip/lib/streams
+ sed -i -E 's/'\''\.\/(streams|util|writer|reader|node-conversions)'\''/'\''\.\/\1\.js'\''/g' ./build/generic-extension-wip/lib/streams/node-conversions.js ./build/generic-extension-wip/lib/streams/reader.js ./build/generic-extension-wip/lib/streams/streams.js ./build/generic-extension-wip/lib/streams/util.js ./build/generic-extension-wip/lib/streams/writer.js
sed: 1: "s/'\.\/(streams|util|wr ...": \1 not defined in the RE

Should I change something to make it work?

Originally posted by @sosnovsky in #4725 (comment)
@tomholub
Copy link
Collaborator Author

tomholub commented Feb 7, 2023

Sorry @sosnovsky , I jumped you here and merged it too early - will leave it to you next time.

You could try deleting node_modules, ensuring to use same npm version as on the CI, then trying again.

@sosnovsky sosnovsky self-assigned this Feb 7, 2023
@sosnovsky
Copy link
Collaborator

I found an issue - it happens only on mac, as it needs to have extension for backup of original files for sed command.
It happened for me in config-mock-build.sh too

@sosnovsky sosnovsky mentioned this issue Feb 7, 2023
Merged
5 tasks
@sosnovsky sosnovsky mentioned this issue Feb 8, 2023
Merged
5 tasks
rrrooommmaaa pushed a commit that referenced this issue Feb 9, 2023
@sosnovsky
#4940 Update build script to not produce .bak files (#4945)
a4f14d6 
* update build script

* rename STREAMS_OUTDIR to STREAMS_FILES
FlowCryptRobot pushed a commit that referenced this issue Feb 22, 2023
@dependabot @ioanmo226
@sosnovsky @rrrooommmaaa @martgil
build(deps-dev): bump @openpgp/web-stream-tools from 0.0.11 to 0.0.13 (…
7f8c02b 
…#4943)

* build(deps-dev): bump @openpgp/web-stream-tools from 0.0.11 to 0.0.13

Bumps [@openpgp/web-stream-tools](https://github.com/openpgpjs/web-stream-tools) from 0.0.11 to 0.0.13.
- [Release notes](https://github.com/openpgpjs/web-stream-tools/releases)
- [Commits](openpgpjs/web-stream-tools@v0.0.11...v0.0.13)

---
updated-dependencies:
- dependency-name: "@openpgp/web-stream-tools"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* #4282 fix: duplicated contact search result (#4944)

* fix: dupliated contact search result

* feat: added ui test

* fix: pr review

* #4940 Update build script to not produce .bak files (#4945)

* update build script

* rename STREAMS_OUTDIR to STREAMS_FILES

* #4844 feat: renew id token when expires (#4949)

* feat: renew id token when expires

* fix: pr reviews

* Employ user verification mechanisms from OpenPGP v5 (#4946)

* reuse getPrimeryUser method

* verifying key users

* allow localhost domain for email address

* fix

* fix and test

* use verified users in key-import-ui

* PR review fixes

---------

Co-authored-by: Roman Shevchenko <[email protected]>

* prevent pasting large input on secure compose (#4914)

* prevent pasting large input on secure compose

* Added type definition for SquireEditor.getRoot()

* apply requested change

* update

* cleanup

* update

* consider selection

* add warning modal

* update

* update

* update

---------

Co-authored-by: Roman Shevchenko <[email protected]>
Co-authored-by: Roman Shevchenko <[email protected]>

* fix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ioan Moldovan <[email protected]>
Co-authored-by: Roma Sosnovsky <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman Shevchenko <[email protected]>
Co-authored-by: Mart G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sosnovsky sosnovsky

Labels
in progress
Projects
None yet
Milestone
8.4.3: Use shared-tenant-fes instead ...
2 participants
@sosnovsky @tomholub