Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4700 Fix mock test #4706

Merged
merged 3 commits into from
Sep 22, 2022
Merged

#4700 Fix mock test #4706

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6d3345
fix: increase passphrase timeout
ioanmo226 Sep 22, 2022
45e0aa6
fix: sleep
ioanmo226 Sep 22, 2022
4b96abb
fix: comment
ioanmo226 Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/source/mock/backend/backend-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class BackendData {
"flags": [
"FORBID_STORING_PASS_PHRASE",
],
"in_memory_pass_phrase_session_length": 3
"in_memory_pass_phrase_session_length": 10
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased session length because when tests run serially in semaphoreci, passphrase might expire(3 seconds length) before getting passphrase.

};
}
if (domain === 'no-submit-client-configuration.flowcrypt.test') {
Expand Down
2 changes: 1 addition & 1 deletion test/source/tests/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ AN8G3r5Htj8olot+jm9mIa5XLXWzMNUZgg==
'cryptup_userpassphrasesessionlengthclientconfigurationflowcrypttest_rules'
]);
let savedPassphrase = await BrowserRecipe.getPassphraseFromInMemoryStore(settingsPage, acctEmail, longid);
expect((rules as { in_memory_pass_phrase_session_length: number }).in_memory_pass_phrase_session_length).to.be.equal(3);
expect((rules as { in_memory_pass_phrase_session_length: number }).in_memory_pass_phrase_session_length).to.be.equal(10);
expect(savedPassphrase).to.be.equal(passphrase);
// wait 1 minute because we delete expired passphrase every 1 minute
await Util.sleep(3);
Expand Down