#4700 Fix mock test #4706

ioanmo226 · 2022-09-22T05:36:33Z

This PR fixed passphrase should expire in in_memory_pass_phrase_session_length mock test issue

close #4700 // if this PR closes an issue

Tests (delete all except exactly one):

Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

addresses the issue it closes (if any)
code is readable and understandable
is accompanied with tests, or tests are not needed
is free of vulnerabilities
is documented clearly and usefully, or doesn't need documentation

ioanmo226 · 2022-09-22T05:39:03Z

test/source/mock/backend/backend-data.ts

@@ -97,7 +97,7 @@ export class BackendData {
        "flags": [
          "FORBID_STORING_PASS_PHRASE",
        ],
-        "in_memory_pass_phrase_session_length": 3
+        "in_memory_pass_phrase_session_length": 10


Increased session length because when tests run serially in semaphoreci, passphrase might expire(3 seconds length) before getting passphrase.

fix: increase passphrase timeout

e6d3345

ioanmo226 requested a review from rrrooommmaaa as a code owner September 22, 2022 05:36

ioanmo226 commented Sep 22, 2022

View reviewed changes

ioanmo226 added 2 commits September 22, 2022 01:51

fix: sleep

45e0aa6

fix: comment

4b96abb

ioanmo226 requested a review from tomholub September 22, 2022 06:14

tomholub approved these changes Sep 22, 2022

View reviewed changes

tomholub merged commit 91d74a8 into master Sep 22, 2022

tomholub deleted the feature/issue-4700 branch September 22, 2022 07:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#4700 Fix mock test #4706

#4700 Fix mock test #4706

ioanmo226 commented Sep 22, 2022

ioanmo226 Sep 22, 2022

#4700 Fix mock test #4706

#4700 Fix mock test #4706

Conversation

ioanmo226 commented Sep 22, 2022

To be filled by reviewers

ioanmo226 Sep 22, 2022

Choose a reason for hiding this comment