-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question on correct use of #bc-ignore! #55
Comments
Hi donellyk, thank you for your question. To be honest, I didn't know you can add comments to labels in Interface Builder, but this sounds very interesting. I might use this myself in the future, thanks for the pointer! Having that said, that it works just out of the box is thanks to @kafejo who requested #15 and implemented it himself in #16, so having comments work is part of BartyCrouch since version 3.1.0. Also note that there is even a test written by @kafejo here which will make sure this feature doesn't break in the future, that should also make sure comments in Interface Builder keep working (so long as they are extracted as comments to the .strings files). I hope this answers your question. Please let this issue open as I want to add this usage possibility to the README and this serves nicely as a TODO for that. I'm happy this library is useful to you! |
Great, thanks for the feedback. |
Closing this as the question was answered. |
This is a life saver! This must be added to the documentation. |
@Dschee please add this to documentation. Allowing to add #bc-ignore! to comment is essential. |
Could you explain why you would need a label text to be untranslatable which you don't want to set in code? I'd like to understand the use case. Cause if you want to set it in code, it's not important what stands in the label in interface builder. I'm actually not a fan of using |
Let's say you design a storyboard view that displays user information. In project we have tens of such strings that are not supposed to be translated. Instead of lot of manual work we simply add Regarding your comment about possible confusion with Please don't disregard Thank you for the great tool. |
I do not disregard Having this said, this is also an open source tool, so if you feel like others would profit from such a feature being documented, feel free to create a PR with an explanation. I would probably merge it. I just don't want to invest time in something I don't believe in. I hope you can understand this. ;) |
I'd like to use
#bc-ignore!
in Interface Builder. For mostly personal preference, I'd rather put it in the comment section, rather then the actual value of a label.This works, and looking at StringsFileUpdater.swift, it doesn't seem to make a difference between keys and comments when looking for the special ignore strings.
I just want to confirm this is expected behavior. I don't want to depend on anything undocumented that might break in the future.
Thanks for all the work on this library, it is exactly what we needed.
The text was updated successfully, but these errors were encountered: