Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#bc-ignore! for NSLocalizedString #15

Closed
kafejo opened this issue Jun 4, 2016 · 2 comments
Closed

#bc-ignore! for NSLocalizedString #15

kafejo opened this issue Jun 4, 2016 · 2 comments
Labels
enhancement

Comments

@kafejo
Copy link

kafejo commented Jun 4, 2016 •
edited by Jeehut
Loading

Is it possible to exclude NSLocalizedStrings that have #bc-ignore! in comment? The use case is that when we use .stringsdict to handle pluralization, we don't need to add these keys into Localizable.strings file.

Example

String.localizedStringWithFormat(NSLocalizedString("%d minute(s) ago", comment: "x minute(s) ago"), components.minute)

The %d minute(s) ago key will be taken from Localizable.stringsdict file, not from Localizable.strings.

Another possible solution is to scan Localizable.stringsdict file for keys and exclude them from Localizable.strings file.
@kafejo
Copy link
Author

kafejo commented Jun 4, 2016

see #16 pull request

@Jeehut Jeehut changed the title #bc-ignore! for NSLocalizableString #bc-ignore! for NSLocalizedString Jun 4, 2016
@Jeehut
Copy link
Member

Jeehut commented Jun 4, 2016

This was implemented in version 3.1.0. Thanks for reporting!

@Jeehut Jeehut closed this as completed Jun 4, 2016
@Jeehut Jeehut mentioned this issue Mar 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kafejo @Jeehut