-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#884 added printing available locales for Android devices #907
Conversation
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
============================================
- Coverage 81.65% 81.40% -0.25%
- Complexity 652 653 +1
============================================
Files 194 197 +3
Lines 3625 3647 +22
Branches 537 541 +4
============================================
+ Hits 2960 2969 +9
- Misses 375 382 +7
- Partials 290 296 +6 |
val cmd = AndroidLocalesListCommand() | ||
CommandLine(cmd).parseArgs("--config=a") | ||
|
||
assertThat(cmd.configPath).isEqualTo("a") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it makes a sense, maybe we can test if the command runs what we expected? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added tests which you suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
0f5c2b0
to
d1d9e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👍
7496448
d1d9e93
to
7496448
Compare
Fixes #884
Test Plan
Use on of a new CLI option to test this PR:
flank firebase test android locales list
orflank android locales list
- print Android available locales to test againstSample Android versions list output:
More listing options of the test environment will be added in the next tasks
Checklist