#810 Prints matrix error as table #819

piotradamczyk5 · 2020-05-27T17:52:17Z

Fixes #810

Checklist

Unit tested
release_notes.md updated

piotradamczyk5 · 2020-05-27T17:55:43Z

test_runner/src/test/kotlin/ftl/util/UtilsTest.kt

        // when
        withGlobalExceptionHandling(block)
-        // then
-        assertTrue(output.log.contains("Error: Matrix failed: 1"))
-        assertTrue(output.log.contains("Error: Matrix failed: 2"))


this test will be updated cause assert methods was not called after System.exit, so I introduced new testing behavior given-will-when 😄 to make them work

Thanks for updating this test 👍

test_runner/src/test/kotlin/ftl/util/LogTableBuilderTest.kt

…e as reference

codecov-commenter · 2020-05-28T06:49:51Z

Codecov Report

Merging #819 into master will increase coverage by 0.37%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##             master     #819      +/-   ##
============================================
+ Coverage     78.30%   78.67%   +0.37%     
- Complexity      667      675       +8     
============================================
  Files           149      152       +3     
  Lines          3014     3090      +76     
  Branches        439      446       +7     
============================================
+ Hits           2360     2431      +71     
- Misses          374      376       +2     
- Partials        280      283       +3

jan-goral · 2020-05-28T17:43:18Z

I wonder if #810 is about displaying only error outputs or maybe also successed. @bootstraponline ?

bootstraponline · 2020-05-28T17:47:18Z

I wonder if #810 is about displaying only error outputs or maybe also successed. @bootstraponline ?

I think we should display the results (failed, success, etc.) for each matrix. Same as gcloud CLI.

jan-goral

Add support for other status types

piotradamczyk5 · 2020-05-29T06:37:27Z

Add support for other status types

I have added printing MatrixResultsReport as table

test_runner/src/main/kotlin/ftl/util/SavedMatrixTableUtil.kt

jan-goral · 2020-05-29T11:45:13Z

test_runner/src/main/kotlin/ftl/reports/MatrixResultsReport.kt

-        }
+        val total = matrices.map.size
+        // unfinished matrix will not be reported as failed since it's still running
+        val success = matrices.map.values.count { it.failed().not() }


jan-goral · 2020-05-29T12:14:53Z

For Debug.kt

    val quantity = "single"
    val type = "error"

Table is printed twice

AndroidArgs
    gcloud:
      results-bucket: test-lab-v9cn46bb990nx-kz69ymd4nm9aq
      results-dir: null
      record-video: false
      timeout: 15m
      async: false
      client-details: 
      network-profile: null
      results-history-name: null
      # Android gcloud
      app: /Users/janek/projects/flank-project/flank-review/test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-debug.apk
      test: /Users/janek/projects/flank-project/flank-review/test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-single-error-debug-androidTest.apk
      additional-apks: 
      auto-google-login: false
      use-orchestrator: true
      directories-to-pull:
        - /sdcard/
      other-files:
      performance-metrics: false
      num-uniform-shards: null
      test-runner-class: null
      test-targets:
      robo-directives:
      robo-script: null
      device:
        - model: NexusLowRes
          version: 28
          locale: en
          orientation: portrait
      num-flaky-test-attempts: 0

    flank:
      max-test-shards: 1
      shard-time: -1
      num-test-runs: 1
      smart-flank-gcs-path: 
      smart-flank-disable-upload: false
      files-to-download:
        - .*/sdcard/[^/]+\.ec$
      test-targets-always-run:
      disable-sharding: true
      project: flank-open-source
      local-result-dir: results
      # Android Flank Yml
      keep-file-path: false
      additional-app-test-apks:
      run-timeout: -1
      legacy-junit-result: false
      ignore-failed-tests: false
      output-style: verbose

RunTests
  Uploading app-debug.apk   Uploading app-single-error-debug-androidTest.apk ..

  1 test / 1 shard

  1 matrix ids created in 0m 6s
  https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-29_12-06-17.849000_lOtW

Matrices webLink
  matrix-23ywqaa9yt86m https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.da0c237aaa33732/matrices/8785051465867885324/executions/bs.f52b9341ebd2e7de

  0m  1s matrix-23ywqaa9yt86m NexusLowRes-28 PENDING
  0m 31s matrix-23ywqaa9yt86m NexusLowRes-28 Starting attempt 1.
  0m 31s matrix-23ywqaa9yt86m NexusLowRes-28 RUNNING
  1m 32s matrix-23ywqaa9yt86m NexusLowRes-28 Started logcat recording.
  1m 32s matrix-23ywqaa9yt86m NexusLowRes-28 Preparing device.
  1m 57s matrix-23ywqaa9yt86m NexusLowRes-28 Installing apps.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Retrieving Pre-Test Package Stats information from the device.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Retrieving Performance Environment information from the device.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Started crash detection.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Started crash monitoring.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Starting instrumentation test.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Completed instrumentation test.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Stopped crash monitoring.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Retrieving Post-test Package Stats information from the device.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Stopped logcat recording.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Done. Test time = 6 (secs)
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Starting results processing. Attempt: 1
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Completed results processing. Time taken = 2 (secs)
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 FINISHED
  2m 33s matrix-23ywqaa9yt86m FINISHED

FetchArtifacts
  .
  Updating matrix file

CostReport
  Virtual devices
    $0.02 for 1m

MatrixResultsReport
  0 / 1 (0.00%)
  1 matrices failed

┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-23ywqaa9yt86m  │                    │
└─────────┴────────────────────────┴────────────────────┘
More details are available at [https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.da0c237aaa33732/matrices/8785051465867885324/executions/bs.f52b9341ebd2e7de]
┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-23ywqaa9yt86m  │                    │
└─────────┴────────────────────────┴────────────────────┘

Process finished with exit code 1

piotradamczyk5 · 2020-05-29T12:22:29Z

For Debug.kt

    val quantity = "single"
    val type = "error"

Table is printed twice

AndroidArgs
    gcloud:
      results-bucket: test-lab-v9cn46bb990nx-kz69ymd4nm9aq
      results-dir: null
      record-video: false
      timeout: 15m
      async: false
      client-details: 
      network-profile: null
      results-history-name: null
      # Android gcloud
      app: /Users/janek/projects/flank-project/flank-review/test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-debug.apk
      test: /Users/janek/projects/flank-project/flank-review/test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-single-error-debug-androidTest.apk
      additional-apks: 
      auto-google-login: false
      use-orchestrator: true
      directories-to-pull:
        - /sdcard/
      other-files:
      performance-metrics: false
      num-uniform-shards: null
      test-runner-class: null
      test-targets:
      robo-directives:
      robo-script: null
      device:
        - model: NexusLowRes
          version: 28
          locale: en
          orientation: portrait
      num-flaky-test-attempts: 0

    flank:
      max-test-shards: 1
      shard-time: -1
      num-test-runs: 1
      smart-flank-gcs-path: 
      smart-flank-disable-upload: false
      files-to-download:
        - .*/sdcard/[^/]+\.ec$
      test-targets-always-run:
      disable-sharding: true
      project: flank-open-source
      local-result-dir: results
      # Android Flank Yml
      keep-file-path: false
      additional-app-test-apks:
      run-timeout: -1
      legacy-junit-result: false
      ignore-failed-tests: false
      output-style: verbose

RunTests
  Uploading app-debug.apk   Uploading app-single-error-debug-androidTest.apk ..

  1 test / 1 shard

  1 matrix ids created in 0m 6s
  https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-29_12-06-17.849000_lOtW

Matrices webLink
  matrix-23ywqaa9yt86m https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.da0c237aaa33732/matrices/8785051465867885324/executions/bs.f52b9341ebd2e7de

  0m  1s matrix-23ywqaa9yt86m NexusLowRes-28 PENDING
  0m 31s matrix-23ywqaa9yt86m NexusLowRes-28 Starting attempt 1.
  0m 31s matrix-23ywqaa9yt86m NexusLowRes-28 RUNNING
  1m 32s matrix-23ywqaa9yt86m NexusLowRes-28 Started logcat recording.
  1m 32s matrix-23ywqaa9yt86m NexusLowRes-28 Preparing device.
  1m 57s matrix-23ywqaa9yt86m NexusLowRes-28 Installing apps.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Retrieving Pre-Test Package Stats information from the device.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Retrieving Performance Environment information from the device.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Started crash detection.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Started crash monitoring.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Starting instrumentation test.
  2m  3s matrix-23ywqaa9yt86m NexusLowRes-28 Completed instrumentation test.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Stopped crash monitoring.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Retrieving Post-test Package Stats information from the device.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Stopped logcat recording.
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Done. Test time = 6 (secs)
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Starting results processing. Attempt: 1
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 Completed results processing. Time taken = 2 (secs)
  2m 33s matrix-23ywqaa9yt86m NexusLowRes-28 FINISHED
  2m 33s matrix-23ywqaa9yt86m FINISHED

FetchArtifacts
  .
  Updating matrix file

CostReport
  Virtual devices
    $0.02 for 1m

MatrixResultsReport
  0 / 1 (0.00%)
  1 matrices failed

┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-23ywqaa9yt86m  │                    │
└─────────┴────────────────────────┴────────────────────┘
More details are available at [https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.da0c237aaa33732/matrices/8785051465867885324/executions/bs.f52b9341ebd2e7de]
┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-23ywqaa9yt86m  │                    │
└─────────┴────────────────────────┴────────────────────┘

Process finished with exit code 1

Basically the first table is a summary report for all matrix (if you have many matrices, it will print them all) and second one log error of each matrix.

To fix this issue I could skip printing table as error log in Utils.kt#withGlobalExceptionHandling this is much decision about how output should look like.

…matrix-error-as-table # Conflicts: # release_notes.md

bootstraponline · 2020-05-29T15:53:27Z

Basically the first table is a summary report for all matrix (if you have many matrices, it will print them all) and second one log error of each matrix.

To fix this issue I could skip printing table as error log in Utils.kt#withGlobalExceptionHandling this is much decision about how output should look like.

I'd study the gcloud CLI matrix table. We should be able to port that to Kotlin.
https://github.com/Flank/gcloud_cli/search?q=TEST_AXIS_VALUE&unscoped_q=TEST_AXIS_VALUE

The end result should be only one table. Primarily the goal of Flank is to match gcloud, and add a bit of extra features on top. 🙂

bootstraponline · 2020-05-29T16:27:26Z

Here's one way you can test the PR:

Run flank.yml with Flank.

flank android run

Run the same flank.yml with gcloud. The table output should match. 🙂

gcloud firebase test android run flank.yml:gcloud

piotradamczyk5 · 2020-06-01T07:48:53Z

I made output table same as for GCloud ( link, single table, status color etc)
I used outcomeDetails to print TEST_DETAILS, but it is usually empty. Should I use other data to print test details? Outcome details in my opinion should be good for it

adamfilipow92 · 2020-06-01T13:20:58Z

I will check outputs
Flank table:

┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-d587bp9k4fcda  │                    │
└─────────┴────────────────────────┴────────────────────┘

and Test Lab

┌─────────┬────────────────────────┬─────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │     TEST_DETAILS    │
├─────────┼────────────────────────┼─────────────────────┤
│ Failed  │ walleye-26-en-portrait │ 1 test cases failed │
└─────────┴────────────────────────┴─────────────────────┘

Colors are the same. But in flank we don't have TEST_DETAILS filled. I don't known its ok so please tell what you think. @bootstraponline @pawelpasterz @jan-gogo

piotradamczyk5 · 2020-06-01T13:48:04Z

I will check outputs
Flank table:

┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-d587bp9k4fcda  │                    │
└─────────┴────────────────────────┴────────────────────┘

and Test Lab

┌─────────┬────────────────────────┬─────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │     TEST_DETAILS    │
├─────────┼────────────────────────┼─────────────────────┤
│ Failed  │ walleye-26-en-portrait │ 1 test cases failed │
└─────────┴────────────────────────┴─────────────────────┘

Colors are the same. But in flank we don't have TEST_DETAILS filled. I don't known its ok so please tell what you think. @bootstraponline @pawelpasterz @jan-gogo

Yes, that's the question which I asked above about properly data usage

I made output table same as for GCloud ( link, single table, status color etc)
I used outcomeDetails to print TEST_DETAILS, but it is usually empty. Should I use other data to print test details? Outcome details in my opinion should be good for it

pawelpasterz · 2020-06-01T13:18:48Z

test_runner/src/test/kotlin/ftl/util/UtilsTest.kt

        // when
        withGlobalExceptionHandling(block)
-        // then
-        assertTrue(output.log.contains("Error: Matrix failed: 1"))
-        assertTrue(output.log.contains("Error: Matrix failed: 2"))


Thanks for updating this test 👍

pawelpasterz · 2020-06-01T14:10:47Z

I will check outputs
Flank table:

┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-d587bp9k4fcda  │                    │
└─────────┴────────────────────────┴────────────────────┘

and Test Lab

┌─────────┬────────────────────────┬─────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │     TEST_DETAILS    │
├─────────┼────────────────────────┼─────────────────────┤
│ Failed  │ walleye-26-en-portrait │ 1 test cases failed │
└─────────┴────────────────────────┴─────────────────────┘

Colors are the same. But in flank we don't have TEST_DETAILS filled. I don't known its ok so please tell what you think. @bootstraponline @pawelpasterz @jan-gogo

Yes, that's the question which I asked above about properly data usage

I made output table same as for GCloud ( link, single table, status color etc)
I used outcomeDetails to print TEST_DETAILS, but it is usually empty. Should I use other data to print test details? Outcome details in my opinion should be good for it

@adamfilipow92
IMO we should try to fix it but in separate issue/PR. If we want to reflect gcloud results I think there would be some refactor needed (small PR scope principle)
https://github.com/Flank/gcloud_cli/blob/cca7556cc832be02b3523c0fe86fdbdcd33078c4/google-cloud-sdk/lib/googlecloudsdk/api_lib/firebase/test/results_summary.py#L326

piotradamczyk5 · 2020-06-01T15:05:52Z

I will check outputs
Flank table:
┌─────────┬────────────────────────┬────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │    TEST_DETAILS    │
├─────────┼────────────────────────┼────────────────────┤
│ failure │  matrix-d587bp9k4fcda  │                    │
└─────────┴────────────────────────┴────────────────────┘
and Test Lab
┌─────────┬────────────────────────┬─────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │     TEST_DETAILS    │
├─────────┼────────────────────────┼─────────────────────┤
│ Failed  │ walleye-26-en-portrait │ 1 test cases failed │
└─────────┴────────────────────────┴─────────────────────┘
Colors are the same. But in flank we don't have TEST_DETAILS filled. I don't known its ok so please tell what you think. @bootstraponline @pawelpasterz @jan-gogo
Yes, that's the question which I asked above about properly data usage

I made output table same as for GCloud ( link, single table, status color etc)
I used outcomeDetails to print TEST_DETAILS, but it is usually empty. Should I use other data to print test details? Outcome details in my opinion should be good for it
@adamfilipow92
IMO we should try to fix it but in separate issue/PR. If we want to reflect gcloud results I think there would be some refactor needed (small PR scope principle)
https://github.com/Flank/gcloud_cli/blob/cca7556cc832be02b3523c0fe86fdbdcd33078c4/google-cloud-sdk/lib/googlecloudsdk/api_lib/firebase/test/results_summary.py#L326

Should I create a task for it?

jan-goral · 2020-06-01T15:43:01Z

@piotradamczyk5

IMO we should try to fix it but in separate issue/PR. If we want to reflect gcloud results I think there would be some refactor needed (small PR scope principle)

I guess It's a good idea If you feel more comfortable with separated issue/PR

piotradamczyk5 · 2020-06-01T15:56:49Z

@piotradamczyk5

IMO we should try to fix it but in separate issue/PR. If we want to reflect gcloud results I think there would be some refactor needed (small PR scope principle)

I guess It's a good idea If you feel more comfortable with separated issue/PR

Created #829

bootstraponline · 2020-06-02T02:39:50Z

I agree, let's match gcloud output. Having this as a new task makes sense. #829 🙂

#810 prints matrix error as table

7e40448

piotradamczyk5 marked this pull request as draft May 27, 2020 17:54

piotradamczyk5 requested review from pawelpasterz, bootstraponline, adamfilipow92 and jan-goral May 27, 2020 17:54

piotradamczyk5 commented May 27, 2020

View reviewed changes

bootstraponline reviewed May 27, 2020

View reviewed changes

test_runner/src/test/kotlin/ftl/util/LogTableBuilderTest.kt Show resolved Hide resolved

jan-goral assigned piotradamczyk5 May 27, 2020

#810 Made comparison with reference table; Make table column size sam…

3d5d627

…e as reference

#810 Update release notes

c75b28d

piotradamczyk5 changed the title ~~#810 prints matrix error as table~~ #810 Prints matrix error as table May 28, 2020

piotradamczyk5 marked this pull request as ready for review May 28, 2020 07:01

jan-goral suggested changes May 28, 2020

View reviewed changes

#810 Added Printing Matrix reports as table

2ff9291

#810 Added Printing Matrix reports as table

1d41f1f

jan-goral reviewed May 29, 2020

View reviewed changes

test_runner/src/main/kotlin/ftl/util/SavedMatrixTableUtil.kt Outdated Show resolved Hide resolved

jan-goral reviewed May 29, 2020

View reviewed changes

test_runner/src/main/kotlin/ftl/util/SavedMatrixTableUtil.kt Outdated Show resolved Hide resolved

jan-goral reviewed May 29, 2020

View reviewed changes

Piotr Adamczyk added 2 commits May 29, 2020 14:24

Merge remote-tracking branch 'origin/master' into #810-added-display-…

be19efa

…matrix-error-as-table # Conflicts: # release_notes.md

#810 Fixing PR comments

9f6e5af

#810 Align output table with GCloud

42c9593

piotradamczyk5 requested review from jan-goral and bootstraponline June 1, 2020 08:49

pawelpasterz previously approved these changes Jun 1, 2020

View reviewed changes

Merge branch 'master' into #810-added-display-matrix-error-as-table

8cfa994

piotradamczyk5 dismissed pawelpasterz’s stale review via 8cfa994 June 1, 2020 15:02

#810 Revert Debug changes

e866fec

piotradamczyk5 requested a review from pawelpasterz June 1, 2020 15:06

jan-goral approved these changes Jun 1, 2020

View reviewed changes

piotradamczyk5 mentioned this pull request Jun 1, 2020

Outcome details is missing in Matrix Report #829

Closed

piotradamczyk5 merged commit c88cb27 into master Jun 1, 2020

piotradamczyk5 deleted the #810-added-display-matrix-error-as-table branch June 1, 2020 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#810 Prints matrix error as table #819

#810 Prints matrix error as table #819

piotradamczyk5 commented May 27, 2020 •

edited

Loading

piotradamczyk5 May 27, 2020

pawelpasterz Jun 1, 2020

codecov-commenter commented May 28, 2020 •

edited

Loading

jan-goral commented May 28, 2020

bootstraponline commented May 28, 2020

jan-goral left a comment

piotradamczyk5 commented May 29, 2020

jan-goral May 29, 2020

jan-goral commented May 29, 2020

piotradamczyk5 commented May 29, 2020

bootstraponline commented May 29, 2020

bootstraponline commented May 29, 2020

piotradamczyk5 commented Jun 1, 2020 •

edited

Loading

adamfilipow92 commented Jun 1, 2020

piotradamczyk5 commented Jun 1, 2020 •

edited

Loading

pawelpasterz Jun 1, 2020

pawelpasterz commented Jun 1, 2020 •

edited

Loading

piotradamczyk5 commented Jun 1, 2020

jan-goral commented Jun 1, 2020 •

edited

Loading

piotradamczyk5 commented Jun 1, 2020

bootstraponline commented Jun 2, 2020

#810 Prints matrix error as table #819

#810 Prints matrix error as table #819

Conversation

piotradamczyk5 commented May 27, 2020 • edited Loading

Checklist

piotradamczyk5 May 27, 2020

Choose a reason for hiding this comment

pawelpasterz Jun 1, 2020

Choose a reason for hiding this comment

codecov-commenter commented May 28, 2020 • edited Loading

Codecov Report

jan-goral commented May 28, 2020

bootstraponline commented May 28, 2020

jan-goral left a comment

Choose a reason for hiding this comment

piotradamczyk5 commented May 29, 2020

jan-goral May 29, 2020

Choose a reason for hiding this comment

jan-goral commented May 29, 2020

piotradamczyk5 commented May 29, 2020

bootstraponline commented May 29, 2020

bootstraponline commented May 29, 2020

piotradamczyk5 commented Jun 1, 2020 • edited Loading

adamfilipow92 commented Jun 1, 2020

piotradamczyk5 commented Jun 1, 2020 • edited Loading

pawelpasterz Jun 1, 2020

Choose a reason for hiding this comment

pawelpasterz commented Jun 1, 2020 • edited Loading

piotradamczyk5 commented Jun 1, 2020

jan-goral commented Jun 1, 2020 • edited Loading

piotradamczyk5 commented Jun 1, 2020

bootstraponline commented Jun 2, 2020

piotradamczyk5 commented May 27, 2020 •

edited

Loading

codecov-commenter commented May 28, 2020 •

edited

Loading

piotradamczyk5 commented Jun 1, 2020 •

edited

Loading

piotradamczyk5 commented Jun 1, 2020 •

edited

Loading

pawelpasterz commented Jun 1, 2020 •

edited

Loading

jan-goral commented Jun 1, 2020 •

edited

Loading