Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outcome details is missing in Matrix Report #829

Closed
piotradamczyk5 opened this issue Jun 1, 2020 · 1 comment · Fixed by #862
Closed

Outcome details is missing in Matrix Report #829

piotradamczyk5 opened this issue Jun 1, 2020 · 1 comment · Fixed by #862
Assignees
@piotradamczyk5
Labels
Bug

Comments

@piotradamczyk5
Copy link
Contributor

piotradamczyk5 commented Jun 1, 2020 •
edited
Loading

Describe the bug
Outcome details is missing in Matrix Report

To Reproduce
Steps to reproduce the behaviour:

  1. Run any test
  2. Check output table with matrix summary

Expected behaviour
Test outcome details should not be empty

Details (please complete the following information):
Latest not release snapshot version with matrix table

Additional context
In PR #819 Flank team discovered that Outcome details are not visible in a matrix report
@pawelpasterz suggested to fix this in separate PR to reflect gcloud results and there is possibility that some refactor would be needed (small PR scope principle)

Please check comment in PR #819
@piotradamczyk5 piotradamczyk5 mentioned this issue Jun 1, 2020
Merged
2 tasks
@piotradamczyk5
Copy link
Contributor Author

piotradamczyk5 commented Jun 8, 2020 •
edited
Loading

This value is now not returned by Google API, that's the reason why it is empty. We must match new outcome details implementation with gcloud

@piotradamczyk5 piotradamczyk5 self-assigned this Jun 9, 2020
piotradamczyk5 pushed a commit that referenced this issue Jun 22, 2020
#829 Added printing outcome details
c2e74c6
@piotradamczyk5 piotradamczyk5 mentioned this issue Jun 22, 2020
Merged
3 tasks
piotradamczyk5 pushed a commit that referenced this issue Jun 23, 2020
#829 update tests
5f9c388
piotradamczyk5 pushed a commit that referenced this issue Jun 23, 2020
#829 update release_notes.md
a70adf1
piotradamczyk5 pushed a commit that referenced this issue Jun 23, 2020
#829 update release_notes.md
ea423a5
piotradamczyk5 pushed a commit that referenced this issue Jun 24, 2020
#829 Added printing outcome details
af1f8b9
piotradamczyk5 pushed a commit that referenced this issue Jun 24, 2020
#829 update tests
d90ce5b
piotradamczyk5 pushed a commit that referenced this issue Jun 24, 2020
#829 update release_notes.md
bc414fa
piotradamczyk5 pushed a commit that referenced this issue Jun 24, 2020
#829 fix OutcomeDetailsFormatter.kt
252771d
piotradamczyk5 pushed a commit that referenced this issue Jun 24, 2020
#829 Fixing pr comments
d60eb38
piotradamczyk5 pushed a commit that referenced this issue Jun 24, 2020
#829 Handle unknown failure
7254b7c
piotradamczyk5 pushed a commit that referenced this issue Jun 25, 2020
#829 Added printing outcome details
3b3adce
piotradamczyk5 pushed a commit that referenced this issue Jun 25, 2020
#829 update tests
429c09e
piotradamczyk5 pushed a commit that referenced this issue Jun 25, 2020
#829 update release_notes.md
16eb962
piotradamczyk5 pushed a commit that referenced this issue Jun 25, 2020
#829 fix OutcomeDetailsFormatter.kt
1f07e43
piotradamczyk5 pushed a commit that referenced this issue Jun 25, 2020
#829 Fixing pr comments
3eaaaf6
piotradamczyk5 pushed a commit that referenced this issue Jun 25, 2020
#829 Handle unknown failure
b06d650
piotradamczyk5 pushed a commit that referenced this issue Jun 29, 2020
#829 Display outcome details based on shards sum
a32e1db
piotradamczyk5 pushed a commit that referenced this issue Jun 29, 2020
#829 Show robo test information
bae8463
piotradamczyk5 pushed a commit that referenced this issue Jun 29, 2020
#829 Fixed flaky outcome
2f2be85
piotradamczyk5 pushed a commit that referenced this issue Jun 30, 2020
#829 Fixed tests and change flaky outcome logic
4bd6ee8
jan-goral added a commit that referenced this issue Jun 30, 2020
@jan-goral
Merge branch 'master' into #829-added-outcome-details
86d1c9f
piotradamczyk5 pushed a commit that referenced this issue Jun 30, 2020
#829 small refactor
c0cd7e8
piotradamczyk5 pushed a commit that referenced this issue Jun 30, 2020
#829 PR fixes
71d0bad
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 Added printing outcome details
195efa7
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 update tests
957bcfc
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 update release_notes.md
a6e0a39
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 fix OutcomeDetailsFormatter.kt
0cc62e3
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 Fixing pr comments
8d3335e
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 Handle unknown failure
943c48f
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 Display outcome details based on shards sum
1949804
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 Show robo test information
ccbbe90
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 Fixed flaky outcome
5ba7230
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 Fixed tests and change flaky outcome logic
418e1f9
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 small refactor
1d58a1a
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 PR fixes
45b4629
piotradamczyk5 pushed a commit that referenced this issue Jul 2, 2020
#829 PR fixes
d911dc5
piotradamczyk5 added a commit that referenced this issue Jul 2, 2020
@piotradamczyk5 @jan-goral
Added printing outcome details (#862)
e1daf1a 
* #829 Added printing outcome details

* #829 update tests

* #829 update release_notes.md

* #829 fix OutcomeDetailsFormatter.kt

* #829 Fixing pr comments

* #829 Handle unknown failure

* Simplify

* Fix test

* Add plant uml diagram for results_summary.py

* Move OutcomeDetailsFormatter.kt to same packet as SavedMatrix.kt

* Fix

* #829 Display outcome details based on shards sum

* Add summary_output.md doc

* #829 Show robo test information

* #829 Fixed flaky outcome

* #829 Fixed tests and change flaky outcome logic

* Fix total count

* Fix total count test

* #829 small refactor

* #829 PR fixes

* #829 PR fixes

Co-authored-by: Janek Góral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotradamczyk5 piotradamczyk5

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added printing outcome details Flank/flank
1 participant
@piotradamczyk5