730 - Refactor jUnit HTML report #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-goral
reviewed
Apr 22, 2020
| }, | ||
| function(err, result) { | ||
| if (err) { console.log(err); } | ||
| var kotlinResource = '../test_runner/src/main/resources/inline.html'; |
There was a problem hiding this comment.
I can't find replacement for this line. @Writhe are you sure that new implementation will update inline.html in resources automatically? I guess we don't want to do copy paste manually after update.
There was a problem hiding this comment.
Ah, good catch - it won't.
I don't think we need this file anywhere other than resources, so I can just tell Webpack to target that directory when building the thing. Would that be ok?
There was a problem hiding this comment.
I can just tell Webpack to target that directory when building the thing. Would that be ok?
Yes, that will work. We don't use inline.html anywhere else.
jan-goral
force-pushed
the
730-refactor-junit-html-report
branch
2 times, most recently
from
f5c3ba5 to
721e9c2
Compare
jan-goral
changed the title
pawelpasterz
previously approved these changes
Apr 30, 2020
jan-goral
force-pushed
the
730-refactor-junit-html-report
branch
from
752881c to
ee32521
Compare
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=========================================
Coverage 78.21% 78.22%
+ Complexity 675 665 -10
=========================================
Files 125 125
Lines 2796 2774 -22
Branches 405 399 -6
=========================================
- Hits 2187 2170 -17
Misses 350 350
+ Partials 259 254 -5 |
pawelpasterz
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor of
/junit_html_report. It replaces CRA with plain TS and simplifies the shape of data expected from Kotlin app (hence the WIP status).TO DO:DONE: