Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor junit_html_report #730

Closed
Writhe opened this issue Apr 21, 2020 · 0 comments · Fixed by #731
Closed

Refactor junit_html_report #730

Writhe opened this issue Apr 21, 2020 · 0 comments · Fixed by #731

Comments

@Writhe
Copy link
Contributor

Writhe commented Apr 21, 2020

Currently, junit_html_report depends on React and a 3rd party UI kit just to display a collapsible list. It works, but...

  • React might be a bit of an overkill in this case,
  • the format of data and the way it's injected in the resulting HTML can be simplified; Right now the shape of data is dictated by the UI kit that consumes it.

My proposition:

  • replace Create React App with either plain JS (or TS) bundled and minified by Webpack
  • replace html inliner with additional step in Webpack build process
  • reshape data into a simple nested structure
  • move data to a separate <script> tag
@jan-goral jan-goral linked a pull request Apr 22, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant