Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution hangs #657

Merged
merged 7 commits into from
Mar 9, 2020
Merged

Fix execution hangs #657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b92fec
Make Utils class more Kotlinish
Mar 7, 2020
67090f5
Implement fix to shut down jvm when main thread is terminated and han…
Mar 8, 2020
2a0f8f5
Update release notes
Mar 8, 2020
6c70271
Update Main.kt
bootstraponline Mar 8, 2020
cc3d31e
Update Debug.kt
bootstraponline Mar 8, 2020
b9ce727
After review changes
Mar 9, 2020
adb4e71
Add test to verify if flank will terminate if non-daemon thread throw…
Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test_runner/src/main/kotlin/ftl/Main.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ class Main : Runnable {
// BugSnag opens a non-daemon thread which will keep the JVM process alive.
// Flank must invoke exitProcess to exit cleanly.
// https://github.com/bugsnag/bugsnag-java/issues/151
exitProcess(CommandLine(Main()).execute(*args))
try {
exitProcess(CommandLine(Main()).execute(*args))
} catch (t: Throwable) {
t.printStackTrace()
exitProcess(CommandLine.ExitCode.SOFTWARE)
}
}
}
}
23 changes: 15 additions & 8 deletions test_runner/src/test/kotlin/Debug.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,19 @@ fun main() {

// Bugsnag keeps the process alive so we must call exitProcess
// https://github.com/bugsnag/bugsnag-java/issues/151
exitProcess(CommandLine(Main()).execute(
"--debug",
"firebase", "test",
"android", "run",
"--dry",
"-c=src/test/kotlin/ftl/fixtures/test_app_cases/flank-$quantity-$type.yml",
"--project=$projectId"
))
try {
exitProcess(
CommandLine(Main()).execute(
"--debug",
"firebase", "test",
"android", "run",
"--dry",
"-c=src/test/kotlin/ftl/fixtures/test_app_cases/flank-$quantity-$type.yml",
"--project=$projectId"
)
)
} catch (t: Throwable) {
t.printStackTrace()
exitProcess(CommandLine.ExitCode.SOFTWARE)
}
}