-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix execution hangs #657
Fix execution hangs #657
Conversation
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
=========================================
Coverage ? 77.62%
Complexity ? 641
=========================================
Files ? 88
Lines ? 2538
Branches ? 333
=========================================
Hits ? 1970
Misses ? 354
Partials ? 214 |
@bootstraponline @remkop |
Looks great! Approved. Thanks for updating and adding the test. |
The classpath in You can get a better classpath from the value of system property |
Thanks for the follow up clarification! I opened #662 to track this work. |
@remkop Omg, I totally missed that ... shame on me. Thanks for catching this! |
Fixes #649
This PR contains commit 2b92fec which is only small refactor which touches quite big number of files. Please, skip this commit when reviewing.
Changes:
CommandLine(Main()).execute(*args)
withexitProcess(...)
which closes jvm (this is workaround for bugsnag bug related to thread pool executor"Checklist