Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Gradle Plugin to check if helpers modules version get updated #2108

Merged
merged 2 commits into from
Jul 30, 2021
Merged

feat: Added Gradle Plugin to check if helpers modules version get updated #2108

merged 2 commits into from
Jul 30, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Jul 29, 2021 •
edited
Loading

Fixes #2063

Test Plan

How do we know the code works?

Version check for :flank_wrapper and :flank_scripts works same as previously

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2021 •
edited
Loading

Timestamp: 2021-07-30 10:59:25
Buildscan url for ubuntu-workflow run 1081954105
https://gradle.com/s/3v6op2svhteoi

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review July 30, 2021 10:50
@bootstraponline bootstraponline force-pushed the 2063_gradle_plugin_to_check_if_version_updated branch from 918eee3 to 12616c0 Compare July 30, 2021 10:51
@Sloox
Copy link
Contributor

Sloox commented Jul 30, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2021 •
edited
Loading

Integration tests succeed for all OSs ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/jijj7z32s4uwo
Linux Build scan: https://gradle.com/s/qaucjrwvo4u3q
Workflow run https://github.com/Flank/flank/actions/runs/1082122218

@piotradamczyk5 piotradamczyk5 changed the title feat: Added Gradle Plugin to check if helpers version updated feat: Added Gradle Plugin to check if helpers modules version get updated Jul 30, 2021
@mergify mergify bot merged commit e2a2ef3 into master Jul 30, 2021
@mergify mergify bot deleted the 2063_gradle_plugin_to_check_if_version_updated branch July 30, 2021 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@Sloox Sloox Sloox approved these changes

@jan-goral jan-goral Awaiting requested review from jan-goral

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop a Gradle plugin for checking if module version is updated
3 participants
@piotradamczyk5 @Sloox @adamfilipow92