Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable GPU acceleration for new instances #1991

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Jun 1, 2021

Fixes #1983

Test Plan

How do we know the code works?

  1. Remove previously created virtual devices in Corellium project.
  2. Run flank corellium test android run -c="./flank_corellium.yml"
  3. Check the newly created devices have enabled GPU acceleration
    • Debug RunTestAndroidCorelliumExample and check flank.corellium.adapter.getCreatedInstances are returning instances with properly configured BootOptions|
    • Or find another way for checking if GPU acceleration is enabled.

Checklist

  • Documented
  • Unit tested

@jan-goral jan-goral self-assigned this Jun 1, 2021
@jan-goral jan-goral requested review from Sloox, pawelpasterz, adamfilipow92, zuziaka and bootstraponline and removed request for Sloox June 1, 2021 09:50
@mergify
Copy link

mergify bot commented Jun 1, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jan-goral jan-goral changed the title Enable GPU acceleration for new instances feat: Enable GPU acceleration for new instances Jun 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Timestamp: 2021-06-01 10:08:36
Buildscan url for ubuntu-workflow run 895596015
https://gradle.com/s/jg25tqblik2kq

@jan-goral jan-goral added the P0 label Jun 1, 2021
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@mergify mergify bot merged commit 6e76e61 into master Jun 1, 2021
@mergify mergify bot deleted the 1983_Enable_GPU_support_for_new_instances branch June 1, 2021 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable GPU support on all provisioned Android devices
3 participants